Closed (fixed)
Project:
Lightbox2
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
12 Aug 2008 at 15:33 UTC
Updated:
4 Oct 2010 at 23:20 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
scottrigbyThis would be very interesting! :) Scott
Comment #2
wuf31 commented+1 for this. What an interesting idea.
Comment #3
stella commentedImplemented in the latest dev release, which won't be available for another 12 hours or so. To get this functionality, you need to install the latest dev release, and then add something like the following to your page.tpl.php:
You can control the size of the lightbox window, either via the config form at admin/settings/lightbox2/html_content - this is a global property which will affect the default size of all modal windows, or by adding a rel attribute like:
Cheers,
Stella
Comment #4
mariusooms commentedWow Stella, that's even better than what I was asking for or expecting. Thanks so much for going the extra mile. Can't wait to give it a spin!
Regards,
Marius
Comment #5
scottrigbygreat! look forward to testing when the next dev release is available...
%^) Scott
Comment #6
mariusooms commentedHi Stella...it works nicely, but almost to nice. In a way for modal messages I'd like them to just appear without the resize animation. Also a set height makes it odd since the message is usually short, but set the height to short and the occasional long messages could get cut off.
So ... would it be possible to have
1) Animation off/on checkbox under HTML Content in admin settings
2) Also have the ability to leave the height field empty so a height is not forced
If not possible by design, would it be possible to manually code this like the example I submitted initially using thickbox? Sorry for being overly requestful ;)
Regards,
Marius
Comment #7
mariusooms commentedSorry...changing status to active to be clear :) I always forget these things...
Regards,
Marius
Comment #8
stella commentedmariusooms: please open a separate feature request. Thanks. I'll try and have a look at it next week.
Cheers,
Stella
Comment #9
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #10
scottrigbyIt's been a little while, but only now got around to testing this --- it's great -- thanks Stella :)
Comment #11
TD540 commentedThis is not working for me guys...
Other images load fine in lightbox, but the Drupal messages just won't show up. I can see them in the outputted html though.
Comment #12
stella commentedReleased in Lightbox2 6.x-1.9 and 5.x-2.9.
Cheers,
Stella
Comment #13
TD540 commentedHey Stella,
Is it now possible to make drupal messages pop up in a Lightbox ?
Grts,
Td.
Comment #14
stella commentedYes, see documentation at http://drupal.org/node/316727
Comment #15
TD540 commentedIt's not working :(
• Lightbox2 module is activated and works correctly for other stuff (like expanding images) ...
• The div #lightboxAutoModal is showing up in the html. I tried putting it right at the beginning of the
<body>, and right before</body>closes. See output here:Comment #16
stella commentedPlease ensure you have upgraded to 6.x-1.9 and have run update.php. If it's still not working, please open a new support request.
Cheers,
Stella
Comment #17
TD540 commentedDefinitelly running 1.9.
Maybe it's because I'm running Drupal 6.9-dev? I'll try rolling back to 6.8 and if it's still not working I'll open a support ticket.
Thanks for the help,
T.
Comment #18
TD540 commentedNope, still not working :(
Comment #19
pounardNot working for me neither. Is there a specific configuration option that we have to set/unset to get this working?
Comment #20
pounardI think 6.x-1.9 code is wrong, you forgot a line when editing the lightbox.js file, which cause the #lightboxAutoModal not to work.
To see this, we have to compare both 5.x-2.9 and 6.x-1.9 versions.
What's missing in 6.x-1.9 version
Just look this grep output:
I'm no expert of JavaScript/jQuery, but I think that in initLightbox() method you are trying to fire the 'click' handler on elements on which it does not exists. You don't seem to set the 'click' event for div#lightboxAutoModal, you only work on 'a' and 'area' with rel parameter in other init functions.
The difference with 5.x-2.9 version
Then, I did this:
See the difference? In 5.x-2.9 version you correctly set the 'click' trigger on *all* #lightboxAutoModal elements. This should work.
Light patch which does better work with me
In 6.x-1.9 version, I did this:
(to apply CC in some file, then do patch -p0 < my_file in lightbox2/js dir).
Which does not seems to works neither, BUT! at least, I have the lightbox-processed class set on my div#lightboxAutoModal, which wasn't there before.
Comment #21
pounardForgot to re-open the bug.
Comment #22
stella commentedThis has been fixed and will be included in the next dev release, available later today - or you can try the attached patch.
Cheers,
Stella
Comment #23
pounardThanks.
Comment #24
stella commentedComment #26
gbernier commentedHey Stella,
Tried this example with the latest Dev release from March 8, 2010, the Modal window now opens but it's appearing blank for me. I can see the messages in the view source but nothing in the modal window.
Comment #27
drupert55 commentedsubscribing
Comment #28
elly commentedHi there - I experienced the same thing as #26. The lightboxAutoModal div displayed all white for me with the dev release, however, the patched version of the current release works fine.
Comment #29
harry slaughterthis functionality seems to be broken again. see related ticket: http://drupal.org/node/783474
Comment #30
Anonymous (not verified) commentedYep, this is still a bug in D6.17 and Lightbox latest dev.
Comment #31
stella commentedThe instructions at http://drupal.org/node/316727 work for me in Garland theme, but it's possibly a duplicate of #325427: lightbox auto-load with lightmodal : #modalContainer is not displayed