Problem/Motivation

The rest_test module is a module for exercising edge cases in the REST module, and is used extensively by REST's integration test coverage.

The JSON API module is porting this test coverage in #2930028. It also wants to test these edge cases, see #2930028-61: Comprehensive JSON API integration test coverage phase 1: for every entity type, individual resources only.

Ironically, the jsonapi module is an alternative to the rest module … but the rest_test module that it wants to reuse in its tests depends on the rest module.

Proposed resolution

There is no reason for the rest_test module to depend on the rest module. Remove this dependency.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 2943338-2.patch557 byteswim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 2943338-2.patch557 bytes
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

The reasons in the #1 are solid.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Patch (to be ported)

Committed a7a9a87 and pushed to 8.6.x. Thanks!

Setting the issue to patch to be ported for cherry-pick once 8.5.0 is out.

  • alexpott committed a7a9a87 on 8.6.x 
    Issue #2943338 by Wim Leers: rest_test module for testing REST module...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Patch (to be ported) » Fixed

Committed dcc8e9d and pushed to 8.5.x. Thanks!

  • alexpott committed 4bddef5 on 8.5.x 
    Issue #2943338 by Wim Leers: rest_test module for testing REST module...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.