I set up the example_block module to build a configurable block for a project. I want to be able to use this block in a panel page.

I can add the block without problems but when I try to 'configure' the block, the link that the Panels module creates is incorrect. I am getting that link through right clicking from the IPE to 'edit block'.

To configure a block, in the case of the example_block module you would need to go to:

http://example.com/admin/structure/block/manage/block_example/example_co...

Yet the IPE creates a link like this:

http://example.com/admin/structure/block/manage/block_example/nfigurable...

As you can see for some reason the URL is messed up and it is stripping off 'example_co' ...

CommentFileSizeAuthor
#8 block_configuration_link_is_wrong-2942953-8.patch622 bytesIevgen Antonovych
#2 block_configuration_link_is_wrong-2942953-2.patch619 bytesIevgen Antonovych
#2 panels_link_issue.jpg321.78 KBIevgen Antonovych
Screen Shot 2018-02-07 at 12.35.14 PM.png49.97 KBvvv8

Comments

vvv8 created an issue. See original summary.

Ievgen Antonovych’s picture

Ievgen Antonovych commented
StatusFileSize
new panels_link_issue.jpg321.78 KB
new block_configuration_link_is_wrong-2942953-2.patch619 bytes

The issue found in screenshot link issue.

I've done fix for this issue.

Ievgen Antonovych’s picture

Ievgen Antonovych commented
Status: Active » Needs review
Ievgen Antonovych’s picture

Ievgen Antonovych commented
ivan berezhnov’s picture

ivan berezhnov commented

I reviewed and for me all ok.
That really fix the bug in Panels.
Thanks @antevgen

ivan berezhnov’s picture

ivan berezhnov commented
Issue tags: +Drupal Ukraine Community
anpolimus’s picture

anpolimus
Primary language Ukrainian
Location Kyiv
commented

@Ievgen Antonovych I thin we have to add limiter to the preg_replace.
This is more safe solution in case if we will have another $subtype_prefix_hyphen in the name

Ievgen Antonovych’s picture

Ievgen Antonovych commented
StatusFileSize
new block_configuration_link_is_wrong-2942953-8.patch622 bytes

Thank you, @anpolimus.

I've already updated

anpolimus’s picture

anpolimus
Primary language Ukrainian
Location Kyiv
commented
Status: Needs review » Reviewed & tested by the community

Looks good for me.

codesquatch’s picture

codesquatch commented

Do we know when this patch will be implemented?

matthiasm11’s picture

matthiasm11 commented

RTBC +1

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

triggered more tests, looks good

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Version: 7.x-3.9 » 7.x-3.x-dev
Status: Reviewed & tested by the community » Fixed

Thanks @Ievgen Antonovych I've reviewed and committed this to the dev branch for the next release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.