Closed (fixed)
Project:
Feeds Tamper
Version:
8.x-2.x-dev
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
6 Feb 2018 at 20:51 UTC
Updated:
12 Mar 2018 at 19:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
max-kuzomko commentedComment #3
max-kuzomko commentedI have rerolled this patch:
Thank you very much @ericgsmith for your help!
Please find attached the patch.
Comment #4
megachrizGood work. I was able to add and edit Tamper plugins for a feed type (as superuser).
A partial review:
I tested with an user that didn't have the administer feeds_tamper permission, but did have 'Tamper My importer feed type' and got an access denied. So the custom access check should check if the user has one of both permissions. Now both are required.
Minor: there should be a test for this newly added method in FeedTypeTamperMetaTest.
I like it that individual parts of the D7 code are removed. This way we can see better what would be left to port later on.
Comment #5
max-kuzomko commentedHi @MegaChriz,
Thanks for the review!
I have fixed 1, 2, 4.
But faced with some issues with the point 3.
Once it is fixed - I will updated the patch.
Comment #6
max-kuzomko commentedAs discussed let's postpone description.
Comment #7
megachriz@max
I've made start with writing up a review (found only tiny things so far) but wasn't able to finish it this week due me feeling a bit ill the last few days. Hopefully I'll be able to finish up the review by Monday.
Comment #10
megachrizCommitted #5 with a few minor changes (see interdiff).
Thanks Max!