CommentFileSizeAuthor
#4 vote_up_down-crashes_in_views-2942608-3.patch778 bytespene
#3 vote_up_down-crashes_in_views-2942608-2.patch1.11 KBdangreenman

Issue fork vote_up_down-2942608

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

asarafraz created an issue. See original summary.

pene’s picture

pene commented

Same error here. I've just installed a fresh new D8, added a Vote content type with only the title and a vote field, and created a view with those two fields showing them from this content type.

dangreenman’s picture

dangreenman commented
Assigned: Unassigned » dangreenman
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new vote_up_down-crashes_in_views-2942608-2.patch1.11 KB

I discovered the element array returned by the viewElements() function in the fieldformatter is malformed (missing an index.)

The patch I have attached appears to fix the issue. Please review.

pene’s picture

pene commented
StatusFileSize
new vote_up_down-crashes_in_views-2942608-3.patch778 bytes

RTBC - It works with the above patch in #3 for 8.x-1.x-dev

It also works with 8.x-1.0-alpha3 and 8.x-1.0-alpha4, however because the code changed a bit (or it looks like half of the patch's code is in the 8.x-1.0-alpha3 release), the updated patch is attached for those versions. Use it or not :)

pene’s picture

pene commented
Version: 8.x-1.0-alpha3 » 8.x-1.0-alpha4
Status: Needs review » Reviewed & tested by the community

Changing status and version. The patch in #3 works with 8.x-1.0-dev, the #4 with 8.x-1.0-alpha3 & 8.x-1.0-alpha4

Pene opened merge request !3

  • marvil07 committed fa0ba42 on 8.x-1.x authored by dangreenman 
    Issue #2942608 by Pene, dangreenman: Adding Vote results to a view...

marvil07 closed merge request !3

marvil07’s picture

marvil07 commented
Assigned: dangreenman » Unassigned
Priority: Critical » Major
Status: Reviewed & tested by the community » Fixed
Related issues: +#2922521: Panelizer entity_field won't display vud votes

Thanks for the changes here!

I have changed a bit the implementation, to follow the pattern mostly used on core field formatters.

It is also important to mention that this change partly reverts 9b2268ae92ca28a88f812caf6dd941f00135b015 related to #2922521: Panelizer entity_field won't display vud votes, but after looking again at that change, I see that it may be only fixing the case panelizer, so I am OK rolling it back, and support for panelizer may need a new change, but hopefully it is a bug to fix there instead.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.