The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.| Comment | File | Size | Author |
|---|---|---|---|
| #4 | vote_up_down-crashes_in_views-2942608-3.patch | 778 bytes | pene |
| #3 | vote_up_down-crashes_in_views-2942608-2.patch | 1.11 KB | dangreenman |
Issue fork vote_up_down-2942608
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 2942608-adding-vote-results
compare - 8.x-1.x changes, plain diff MR !3
Comments
Comment #2
pene commentedSame error here. I've just installed a fresh new D8, added a Vote content type with only the title and a vote field, and created a view with those two fields showing them from this content type.
Comment #3
dangreenman commentedI discovered the element array returned by the viewElements() function in the fieldformatter is malformed (missing an index.)
The patch I have attached appears to fix the issue. Please review.
Comment #4
pene commentedRTBC - It works with the above patch in #3 for 8.x-1.x-dev
It also works with 8.x-1.0-alpha3 and 8.x-1.0-alpha4, however because the code changed a bit (or it looks like half of the patch's code is in the 8.x-1.0-alpha3 release), the updated patch is attached for those versions. Use it or not :)
Comment #5
pene commentedChanging status and version. The patch in #3 works with 8.x-1.0-dev, the #4 with 8.x-1.0-alpha3 & 8.x-1.0-alpha4
Comment #9
marvil07 commentedThanks for the changes here!
I have changed a bit the implementation, to follow the pattern mostly used on core field formatters.
It is also important to mention that this change partly reverts 9b2268ae92ca28a88f812caf6dd941f00135b015 related to #2922521: Panelizer entity_field won't display vud votes, but after looking again at that change, I see that it may be only fixing the case panelizer, so I am OK rolling it back, and support for panelizer may need a new change, but hopefully it is a bug to fix there instead.