Problem/Motivation

#2882717: EntityResourceTestBase: assert that PATCHed and POSTed entities contain the intended values tightened the POST REST test coverage. But it was unable to make its assertion work for the Term entity type due to a bug in that entity type. That bug was being fixed in #2543726: Make $term->parent behave like any other entity reference field, to fix REST and Migrate support and de-customize its Views integration.

But #2543726 did not remove that work-around.

Proposed resolution

Remove the work-around that #2882717 introduced and that #2543726 should have removed but did not.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 2942522-2.patch1.5 KBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 2942522-2.patch1.5 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Simple enough cleanup. The tests pass and this is a test-only change so I did not manually test this. Great work Wim!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 678a4c8 and pushed to 8.6.x. Thanks!

Not back ported cause #2543726: Make $term->parent behave like any other entity reference field, to fix REST and Migrate support and de-customize its Views integration is 8.6.x only.

  • alexpott committed 678a4c8 on 8.6.x 
    Issue #2942522 by Wim Leers: Follow-up for #2543726: remove work-around...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.