Need cleanup codebase according to coding standarts (we can use phpcs as base)

CommentFileSizeAuthor
#8 lang_dropdown-clean_up_the_codebase-2941850-8.patch63.67 KBsamvel
#6 lang_dropdown-clean_up_the_codebase-2941850-5.patch53.09 KBsamvel
#3 lang_dropdown-clean_up_the_codebase-2941850-3.patch53.38 KBsamvel

Comments

Samvel created an issue. See original summary.

samvel’s picture

samvel commented

Const names changed in #2941846: Const names

samvel’s picture

samvel commented
Status: Active » Needs review
StatusFileSize
new lang_dropdown-clean_up_the_codebase-2941850-3.patch53.38 KB
kala4ek’s picture

kala4ek
Primary language Russian
Location 🇷🇺 Novosibirsk
commented
Assigned: samvel » kala4ek
kala4ek’s picture

kala4ek
Primary language Russian
Location 🇷🇺 Novosibirsk
commented
Assigned: kala4ek » Unassigned
Category: Bug report » Task
Status: Needs review » Needs work

Seems patch need to be recreated:

$ git apply lang_dropdown-clean_up_the_codebase-2941850-3.patch
lang_dropdown-clean_up_the_codebase-2941850-3.patch:43: trailing whitespace.
  border: 1px solid #aaaacc;
lang_dropdown-clean_up_the_codebase-2941850-3.patch:44: trailing whitespace.
  background: none repeat scroll 0 0 #c3c3e3 !important;
lang_dropdown-clean_up_the_codebase-2941850-3.patch:45: trailing whitespace.
  border-radius: 2px;
lang_dropdown-clean_up_the_codebase-2941850-3.patch:46: trailing whitespace.
  cursor: pointer;
lang_dropdown-clean_up_the_codebase-2941850-3.patch:47: trailing whitespace.
  position: relative;
error: patch failed: lang_dropdown.module:1
error: lang_dropdown.module: patch does not apply
samvel’s picture

samvel commented
Status: Needs work » Needs review
StatusFileSize
new lang_dropdown-clean_up_the_codebase-2941850-5.patch53.09 KB

Patch rerolled

Status: Needs review » Needs work

The last submitted patch, 6: lang_dropdown-clean_up_the_codebase-2941850-5.patch, failed testing. View results

samvel’s picture

samvel commented
Status: Needs work » Needs review
StatusFileSize
new lang_dropdown-clean_up_the_codebase-2941850-8.patch63.67 KB

  • kala4ek committed a872a43 on 7.x-2.x authored by Samvel 
    Issue #2941850 by Samvel, kala4ek: Clean up the codebase
kala4ek’s picture

kala4ek
Primary language Russian
Location 🇷🇺 Novosibirsk
commented
Status: Needs review » Fixed

Committed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.