Problem/Motivation

There is an extra settings: { } in config/install/field.storage.commerce_order_item.subscription.yml which is overriding the real 

settings:
  target_type: commerce_subscription

to do not be taken into account and cause the field to be installed with target_type: node.

Proposed resolution

Remove settings: { }

Remaining tasks

Patch coming shortly.

CommentFileSizeAuthor
#2 commerce_recurring-extras_settings-2940748-2.patch844 bytesnikathone

Comments

nikathone created an issue. See original summary.

nikathone’s picture

nikathone
Primary language Swahili
Location Ontario
commented
StatusFileSize
new commerce_recurring-extras_settings-2940748-2.patch844 bytes

And the small patch.

nikathone’s picture

nikathone
Primary language Swahili
Location Ontario
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: commerce_recurring-extras_settings-2940748-2.patch, failed testing. View results

joachim’s picture

joachim commented
Status: Needs work » Reviewed & tested by the community

Branch tests are failing.

This patch looks good to me. Good catch!

nikathone’s picture

nikathone
Primary language Swahili
Location Ontario
commented

Also created a pull request at https://github.com/bojanz/commerce_recurring/pull/32

  • bojanz committed e97a2e6 on 8.x-1.x authored by nikathone 
    Issue #2940748 by nikathone: Extras settings in field.storage....
bojanz’s picture

bojanz commented
Status: Reviewed & tested by the community » Fixed

Thanks! It is a mystery to me how this happened.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.