Move recipe instruction out of csv file in to their own text file.

This looks good to me and makes the CSV with things like alt tags for images waaaaay easier to read/edit. Marking as RTBC (this was also discussed on the weekly call today).

+++ b/core/profiles/demo_umami/modules/demo_umami_content/src/InstallHelper.php
@@ -219,7 +219,12 @@ protected function importRecipes() {
+          $recipe_instruction_handle = fopen($recipe_instruction_path, 'r');
...
+            $recipe_instructions = fread($recipe_instruction_handle, filesize($recipe_instruction_path));

any reason not to use file_get_contents instead here, no need to use fread/fsize/fopen dance for such small files

We need a test for the .htaccess protection.

See #2941488: Add a .htaccess file to core/profiles/demo_umami/modules/demo_umami_content/default_content/images to prevent direct downloading of images for sample test.

+++ b/core/profiles/demo_umami/modules/demo_umami_content/default_content/recipe_instructions/.htaccess
@@ -0,0 +1,23 @@
+# Set the catch-all handler to prevent scripts from being executed.
+SetHandler Drupal_Security_Do_Not_Remove_See_SA_2006_006
+<Files *>
+  # Override the handler again if we're run later in the evaluation list.
+  SetHandler Drupal_Security_Do_Not_Remove_See_SA_2013_003
+</Files>
+
+# If we know how to do it safely, disable the PHP engine entirely.
+<IfModule mod_php5.c>
+  php_flag engine off
+</IfModule>

I don't think we need this, there are no php files in this folder right?

I can't access images by going directly to their file.
I can't access html files by going directly to their file.
.htaccess for php is removed

Let's RTBC this.

+++ b/core/profiles/demo_umami/modules/demo_umami_content/default_content/recipe_instructions/chocolate-brownie-umami.html
@@ -0,0 +1,9 @@
+<ol>
+  <li>Preheat the oven to 180C and grease a 8 inch cake tin.</li>
+  <li>Sift the flour and cocoa powder into a bowl and add the sugar and salt.</li>
+  <li>Add the oil, a little at time, mixing well to avoid lumps. Add the soy milk and vanilla extract and mix thoroughly.
+  </li>
+  <li>Gently pour into the cake tin and spread out until even. Bake for about 15 minutes and check with a knife (the knife should come out clean when inserted into the brownies 2cm from the edge).
+  </li>
+  <li>Allow to cool in the tin for a few minutes before cooling on a wire rack.</li>
+</ol>

What is the reason for some closing list items on its own line? Should they all be oneliners instead?

Here's a patch that updates @eli-t's patch in #8 with fixes for @Gábor Hojtsy's feedback turning all the list items's into one liners.

Sorry, interdiff for the previous comment.

It's a thing of beauty! Thanks @gabor for the suggestion.

Whilst reviewing this, I checked if we had test coverage for body fields already, which would verify that this feature worked.

But unfortunately, we don't.

We already have \Drupal\Tests\demo_umami_content\Functional\UninstallDefaultContentTest::assertRecipesImported

In which we do this

$this->assertCount(1, $nodes);

Can we add the following:

$node = reset($nodes);
$this->assertContains('Mix the some of the milk and water in a jug', $node->field_recipe_instructions->processed);

Then we're sure this doesn't get broken in the future.

This should be good.

Instructions are in proper format. Here's an example:

Direct access to file results in forbidden response:

Thanks for taking care of all the bits raised, committed!

+++ b/core/profiles/demo_umami/modules/demo_umami_content/tests/src/Functional/UninstallDefaultContentTest.php
@@ -90,7 +90,7 @@
+    $this->assertContains('Mix the some of the milk and water in a jug', $node->field_recipe_instruction->value);

I would like to point out that the chosen sample text has some language issues: "the some of the" does not sound correct :) That said this is a pre-existing problem and can in fact be fixed easier once the files are on their own.