Problem/Motivation

The Media module ships with some default configuration, either in the module or in the standard install profile. However, there is no test to ensure that this configuration, when installed, is what we expect.

It turns out that some improvements fixed in recent issues do provoke that the active configuration ends up different from the default files.

Proposed resolution

Fix it and add a test to ensure it doesn't happen again.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#34 2940205-nr-bot.txt149 bytesneeds-review-queue-bot
#24 interdiff_21-24.txt1.06 KBvsujeetkumar
#24 2940205_24.patch5.46 KBvsujeetkumar
#21 interdiff_19-21.txt1.96 KBvsujeetkumar
#21 2940205_21.patch5.58 KBvsujeetkumar
#19 2940205_19.patch4.88 KBvsujeetkumar
#15 2940205-15.patch6.9 KBkostyashupenko
#6 interdiff-3-6.txt592 bytesmarcoscano
#6 2940205-6.patch6.92 KBmarcoscano
#3 interdiff-2-3.txt2.84 KBmarcoscano
#3 2940205-3.patch6.34 KBmarcoscano
#2 2940205-2-FAIL.patch3.5 KBmarcoscano

Issue fork drupal-2940205

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

marcoscano created an issue. See original summary.

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
commented
Status: Active » Needs review
StatusFileSize
new 2940205-2-FAIL.patch3.5 KB

Here the failing test to demonstrate the issue.

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
commented
Assigned: marcoscano » Unassigned
StatusFileSize
new 2940205-3.patch6.34 KB
new interdiff-2-3.txt2.84 KB

And now with the fix.

The last submitted patch, 2: 2940205-2-FAIL.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 3: 2940205-3.patch, failed testing. View results

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
commented
Status: Needs work » Needs review
StatusFileSize
new 2940205-6.patch6.92 KB
new interdiff-3-6.txt592 bytes

And now with the fix and also updating other affected tests.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

seanb’s picture

seanb
Primary language Dutch
Location Netherlands
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

We have added at least remote video (maybe some other config as well). I think this needs a reroll.
Otherwise, looking good and very useful to me!

seanB credited chr.fritsch.

seanB credited phenaproxima.

seanB credited starshaped.

seanB credited tstoeckler.

seanb’s picture

seanb
Primary language Dutch
Location Netherlands
commented
kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 2940205-15.patch6.9 KB
seanb’s picture

seanb
Primary language Dutch
Location Netherlands
commented
Status: Needs review » Needs work 
+++ b/core/modules/media/tests/src/Functional/ConfigCheckTest.php
@@ -0,0 +1,96 @@
+    // Only test the config provided by the media module.
+    $config_names = [

I think the remote video config also needs to be added to the list of config names we want to test.

field.field.media.remote_video.field_media_oembed_video.yml
core.entity_form_display.media.remote_video.default.yml
field.storage.media.field_media_oembed_video.yml
core.entity_view_display.media.remote_video.default.yml
media.type.remote_video.yml

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

vsujeetkumar’s picture

vsujeetkumar commented
Status: Needs work » Needs review
StatusFileSize
new 2940205_19.patch4.88 KB

Re-roll patch created for 9.1.x.

Status: Needs review » Needs work

The last submitted patch, 19: 2940205_19.patch, failed testing. View results

vsujeetkumar’s picture

vsujeetkumar commented
StatusFileSize
new 2940205_21.patch5.58 KB
new interdiff_19-21.txt1.96 KB

Changes has been made according to #16 and fixed the test, Please check.

vsujeetkumar’s picture

vsujeetkumar commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 21: 2940205_21.patch, failed testing. View results

vsujeetkumar’s picture

vsujeetkumar commented
Status: Needs work » Needs review
StatusFileSize
new 2940205_24.patch5.46 KB
new interdiff_21-24.txt1.06 KB

Fixed the test, Please check.

Status: Needs review » Needs work

The last submitted patch, 24: 2940205_24.patch, failed testing. View results

vsujeetkumar’s picture

vsujeetkumar commented
Status: Needs work » Needs review
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Issue tags: +Triaged Media Initiative issue

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

phenaproxima opened merge request !865

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 2940205-nr-bot.txt149 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.