Problem/Motivation

Umami currently uses the default "drag-and-drop + Add another item" multiple value implementation for managing categories and tags for recipes.

Partial screenshot of the Umami recipe edit page with the Recipe Category and Tags fields in the center

We have a "Tags-style autocompletion" widget, which allows autocompleting multiple items in a single textfield. This makes for better usability in this case, I think.

Proposed resolution

Use tags-style autocomplete widget instead.

CommentFileSizeAuthor
#6 tag-confirmation.jpeg291.76 KBkpolte
#5 tag-style-autocompletion-2939747-5.patch903 bytesadiaz
umami-taxonomy.jpeg196.68 KBtstoeckler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler created an issue. See original summary.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler at bio.logis Genetic Information Management GmbH commented

Not sure if there were any specific reasons for using the current widgets, and I'm not much of a usability person, so maybe this is just "closed (works as designed)" but I thought I'd point it out. Seems to me at least that this would be an improvement.

markconroy’s picture

markconroy CreditAttribution: markconroy as a volunteer and at Annertech commented
Issue tags: +dclondon, +Novice
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler at bio.logis Genetic Information Management GmbH commented
Issue tags: +dcruhr18
adiaz’s picture

adiaz
he/him
Primary language Spanish
Location San José, Costa Rica
CreditAttribution: adiaz at Manatí commented
Status: Active » Needs review
FileSize
tag-style-autocompletion-2939747-5.patch903 bytes

I agree, tag style autocompletion may improve usability. Here's a patch for review.

kpolte’s picture

kpolte CreditAttribution: kpolte commented
Issue summary: View changes
FileSize
tag-confirmation.jpeg291.76 KB

Testet patch in recipe category and tags plus attached a schreenshot. Works perfect :D

recipe category and tags

kpolte’s picture

kpolte CreditAttribution: kpolte commented
Status: Needs review » Reviewed & tested by the community
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler as a volunteer commented
Status: Reviewed & tested by the community » Needs review

Thanks @kpolte, that's awesome. Code looks great as well. RTBC++

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs review » Reviewed & tested by the community

The status change in #8 seems accidental.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler as a volunteer commented

Oops, sorry, yeah that was stupid.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: tag-style-autocompletion-2939747-5.patch, failed testing. View results

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler as a volunteer commented
Status: Needs work » Reviewed & tested by the community

Hmm... failed on:

PHP Fatal error: Uncaught Error: Call to undefined method GuzzleHttp\Psr7\Response::onFrame() in /opt/drupalci/testrunner/src/DrupalCI/Build/Environment/Environment.php:362

Assuming that's an issue with the bot so setting back to RTBC

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Version: 8.6.x-dev » 8.5.x-dev

Totally makes sense for me to use the tags autocompletion for these fields.

Committed 71f416b and pushed to 8.6.x. Thanks!

Leaving RTBC against 8.5.x.

  • lauriii committed 71f416b on 8.6.x 
    Issue #2939747 by adiaz, tstoeckler, kpolte: Use tags-style...

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: tag-style-autocompletion-2939747-5.patch, failed testing. View results

  • lauriii committed 6fe9dd9 on 8.5.x 
    Issue #2939747 by adiaz, tstoeckler, kpolte: Use tags-style...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Needs work » Fixed

Cherry-picked 6fe9dd9 and pushed to 8.5.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.