There are some coding standards issues that will be great to fix. @shumer, if you don't mind we will do it on Lutsk code sprint :)

Here is the summary:

PHP CODE SNIFFER REPORT SUMMARY
----------------------------------------------------------------------
FILE                                                  ERRORS  WARNINGS
----------------------------------------------------------------------
.../modules/contrib/config_pages/config_pages.module  12      4
...modules/contrib/config_pages/config_pages.install  4       1
...ntrib/config_pages/src/Entity/ConfigPagesType.php  9       2
...ntrib/config_pages/src/ConfigPagesListBuilder.php  3       1
...ges/src/Form/ConfigPagesClearConfirmationForm.php  1       2
...nfig_pages/src/Form/ConfigPagesTypeDeleteForm.php  0       2
...b/config_pages/src/ConfigPagesTypeListBuilder.php  0       1
...ntrib/config_pages/src/ConfigPagesContextBase.php  4       0
...contrib/config_pages/src/ConfigPagesInterface.php  1       6
...contrib/config_pages/src/ConfigPagesViewsData.php  1       0
.../config_pages/src/ConfigPagesContextInterface.php  3       0
...ib/config_pages/src/Routing/ConfigPagesRoutes.php  2       0
...ules/contrib/config_pages/src/ConfigPagesForm.php  0       3
...onfig_pages/src/Annotation/ConfigPagesContext.php  1       0
...ib/config_pages/src/ConfigPagesContextManager.php  4       0
..._pages/src/ConfigPagesContextManagerInterface.php  1       0
...ig_pages/src/Controller/ConfigPagesController.php  4       2
.../contrib/config_pages/src/ConfigPagesTypeForm.php  9       4
...onfig_pages/src/Plugin/Block/ConfigPagesBlock.php  1       4
..._pages/src/Plugin/ConfigPagesContext/Language.php  5       0
...ebase/web/modules/contrib/config_pages/README.txt  0       24
----------------------------------------------------------------------
A TOTAL OF 65 ERRORS AND 56 WARNINGS WERE FOUND IN 21 FILES
----------------------------------------------------------------------

Comments

Matroskeen created an issue. See original summary.

ioana apetri’s picture

Can I work on it?Thanks

matroskeen’s picture

@yo30 if you want to be a part of Drupal Global Sprint Weekend at Lutsk you are welcome! :)

ioana apetri’s picture

Yep , thanks:) I have joined the group.

ioana apetri’s picture

Assigned: Unassigned » ioana apetri
matroskeen’s picture

Hello @yo30,

Are you working on this issue? Will you work on other issues tomorrow?

Can you contact me via the Drupal contact form, please? Thanks! :)

ioana apetri’s picture

Yes, I am working on it.

ioana apetri’s picture

Assigned: ioana apetri » Unassigned
Status: Active » Needs review
StatusFileSize
new26.37 KB

Here's the patch. Please review. Thanks

  • shumer committed 8331e16 on 8.x-2.x authored by yo30
    Issue #2939502 by yo30: Coding standards errors
    
shumer’s picture

Status: Needs review » Fixed

  • shumer committed d606fab on 8.x-2.x
    Issue #2939502 by yo30, shumer: Coding standards errors
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

artaphis’s picture

In src/Plugin/ConfigPagesContext/Language.php LanguageManager is used incorrectly:

$this->language_manager

and

$this->languageManager

I produces Call to a member function getCurrentLanguage() on null in Drupal\config_pages\Plugin\ConfigPagesContext\Language->getValue() error.