Once a draft is created for a node, we should prevent further edits using Geysir on the published revision. If not, conflicts will arise between the latest revision (draft) and the published revision. I would say edits directly on the published revision should remain possible (to correct typos e.g., but once a draft is present, this should be prevented. Solution would be to hide the Geysir controls when needed.

Comments

vollepeer created an issue. See original summary.

pookmish’s picture

Kinda on this topic (please let me know if a new issue should be made), After there is a published revision created, I would like to make several changes before publishing again. This is a real blocker for me being able to use this module. My idea is that a user can add/delete a paragraph. Once doing so, it would create a new unpublished revision that the user is editing. Near the bottom or somewhere there would be a "Publish" button (or similar if moderation is in place) that would then push the changes live.

vollepeer’s picture

Hi pookmish,

The current dev release of Geysir integrates with the new workflow system in Drupal 8.5. If you have a published version available, you can simple create a new draft by editing the node and safe as draft. Next you can use Geysir to alter the content of the page and publish the revision when ready.

pookmish’s picture

Yeah i have tried that out. However, I think that defeats the purpose of this module if a user has to first go to the edit page, make no changes and click save. then do their changes and go back to the edit page to publish and save. Wouldn't it be better to stay on one page, make all your changes and after you're done, then click a publish button near the bottom?

vollepeer’s picture

Yes indeed. We have created a few mock-ups of how such functionality could look like (see attachments). It could be positioned in the black admin toolbar e.g.

vollepeer’s picture

Fixed for now in dev branch. Only edits on the latest revision are now allowed (this is also how Drupal handles revision by default)

vollepeer’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.