Author attributes populated with unrelated data [#2938959]

Comment	File	Size	Author
#24	author-attrib-2938959-24.patch	9.55 KB	markdorison
#22	author-attrib-2938959-22.patch	9.55 KB	markdorison
#20	author-attrib-2938959-20.patch	9.51 KB	markdorison
#18	author-attrib-2938959-18-testsonly.patch	7.67 KB	markdorison
#17	author-attrib-2938959-17-testsonly.patch	6.59 KB	markdorison
#16	author-attrib-2938959-16.patch	8.43 KB	markdorison
#15	author-attrib-2938959-15.patch	7.64 KB	markdorison
#11	author-attrib-2938959-11.patch	1.84 KB	markdorison
#9	author-attrib-2938959-9.patch	7.64 KB	markdorison
#7	author-attrib-2938959-7.patch	8.33 KB	markdorison
#5	author-attrib-2938959-5.patch	8.43 KB	markdorison
#3	author-attrib-2938959-2.patch	8.46 KB	markdorison
#2	author-attrib-2938959-1-tests-only.patch	6.63 KB	markdorison

Comment #1

23 January 2018 at 18:45

markdorison created an issue. See original summary.

Log in or register to post comments

Comment #2

markdorison

he/him

commented 23 January 2018 at 18:56

Status:

Active

» Needs review

Status	File	Size
new	author-attrib-2938959-1-tests-only.patch	6.63 KB

This patch includes new tests only.

Log in or register to post comments

Comment #3

markdorison

he/him

commented 23 January 2018 at 19:08

Status	File	Size
new	author-attrib-2938959-2.patch	8.46 KB

Tests still need work.

Log in or register to post comments

Comment #4

23 January 2018 at 19:12

Status:

Needs review

» Needs work

The last submitted patch, 3: author-attrib-2938959-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Log in or register to post comments

Comment #5

markdorison

he/him

commented 24 January 2018 at 22:53

Status:

Needs work

» Needs review

Status	File	Size
new	author-attrib-2938959-5.patch	8.43 KB

Updated tests.

Log in or register to post comments

Comment #6

24 January 2018 at 22:58

Status:

Needs review

» Needs work

The last submitted patch, 5: author-attrib-2938959-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Log in or register to post comments

Comment #7

markdorison

he/him

commented 29 January 2018 at 21:46

Status:

Needs work

» Needs review

Status	File	Size
new	author-attrib-2938959-7.patch	8.33 KB

Updated test.

Log in or register to post comments

Comment #8

29 January 2018 at 21:50

Status:

Needs review

» Needs work

The last submitted patch, 7: author-attrib-2938959-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Log in or register to post comments

Comment #9

markdorison

he/him

commented 29 January 2018 at 21:53

Status:

Needs work

» Needs review

Status	File	Size
new	author-attrib-2938959-9.patch	7.64 KB

Removed new tests.

Log in or register to post comments

Comment #10

29 January 2018 at 21:56

Status:

Needs review

» Needs work

The last submitted patch, 9: author-attrib-2938959-9.patch, failed testing. View results

Log in or register to post comments

Comment #11

markdorison

he/him

commented 29 January 2018 at 21:58

Status:

Needs work

» Needs review

Status	File	Size
new	author-attrib-2938959-11.patch	1.84 KB

No tests.

Log in or register to post comments

Comment #12

29 January 2018 at 22:02

Status:

Needs review

» Needs work

The last submitted patch, 11: author-attrib-2938959-11.patch, failed testing. View results

Log in or register to post comments

Comment #13

markdorison

he/him

commented 29 January 2018 at 22:07

3 files were hidden/shown/deleted

Status	File	Size
hidden	author-attrib-2938959-2.patch	8.46 KB
hidden	author-attrib-2938959-7.patch	8.33 KB
hidden	author-attrib-2938959-9.patch	7.64 KB

#11 is working in my testing. I am not yet why the tests are failing.

Log in or register to post comments

Comment #14

markdorison

he/him

commented 29 January 2018 at 22:08

1 file was hidden/shown/deleted

Status	File	Size
hidden	author-attrib-2938959-1-tests-only.patch	6.63 KB

Log in or register to post comments

Comment #15

markdorison

he/him

commented 29 January 2018 at 22:37

Status:

Needs work

» Needs review

Status	File	Size
new	author-attrib-2938959-15.patch	7.64 KB

Added changes to test view.

Log in or register to post comments

Comment #16

markdorison

he/him

commented 29 January 2018 at 22:44

Status	File	Size
new	author-attrib-2938959-16.patch	8.43 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	author-attrib-2938959-5.patch	8.43 KB

Added new tests for presence of tag and author fields.

Log in or register to post comments

Comment #17

markdorison

he/him

commented 30 January 2018 at 19:37

Status	File	Size
new	author-attrib-2938959-17-testsonly.patch	6.59 KB

Tests only.

Log in or register to post comments

Comment #18

markdorison

he/him

commented 30 January 2018 at 19:46

Status	File	Size
new	author-attrib-2938959-18-testsonly.patch	7.67 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	author-attrib-2938959-17-testsonly.patch	6.59 KB

Log in or register to post comments

Comment #19

30 January 2018 at 19:53

Status:

Needs review

» Needs work

The last submitted patch, 18: author-attrib-2938959-18-testsonly.patch, failed testing. View results

Log in or register to post comments

Comment #20

markdorison

he/him

commented 30 January 2018 at 19:56

Status:

Needs work

» Needs review

Status	File	Size
new	author-attrib-2938959-20.patch	9.51 KB

Log in or register to post comments

Comment #21

30 January 2018 at 19:59

Status:

Needs review

» Needs work

The last submitted patch, 20: author-attrib-2938959-20.patch, failed testing. View results

Log in or register to post comments

Comment #22

markdorison

he/him

commented 30 January 2018 at 20:03

Status:

Needs work

» Needs review

Status	File	Size
new	author-attrib-2938959-22.patch	9.55 KB

Log in or register to post comments

Comment #23

markdorison

he/him

commented 30 January 2018 at 20:19

5 files were hidden/shown/deleted

Status	File	Size
hidden	author-attrib-2938959-11.patch	1.84 KB
hidden	author-attrib-2938959-15.patch	7.64 KB
hidden	author-attrib-2938959-16.patch	8.43 KB
hidden	author-attrib-2938959-18-testsonly.patch	7.67 KB
hidden	author-attrib-2938959-20.patch	9.51 KB

Log in or register to post comments

Comment #24

markdorison

he/him

commented 30 January 2018 at 20:21

Status	File	Size
new	author-attrib-2938959-24.patch	9.55 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	author-attrib-2938959-22.patch	9.55 KB

Added type-hint to array parameter.

Log in or register to post comments

Comment #25

30 January 2018 at 20:42

markdorison committed 667d9b5 on 8.x-1.x

Issue #2938959 by markdorison: Author attributes populated with...

Log in or register to post comments

Comment #26

markdorison

he/him

commented 30 January 2018 at 20:42

Status:

Needs review

» Fixed

Log in or register to post comments

Comment #27

karlshea

he/him

English

Minneapolis 🇺🇸

commented 31 January 2018 at 05:28

The last fixes all look good to me, do you want to tag 8.x-1.1?

Log in or register to post comments

Comment #28

markdorison

he/him

commented 31 January 2018 at 14:31

@KarlShea Good idea; done.

Log in or register to post comments

Comment #29

14 February 2018 at 14:34

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Log in or register to post comments

Author attributes populated with unrelated data

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

Comment #20

Comment #21

Comment #22

Comment #23

Comment #24

Comment #25

Comment #26

Comment #27

Comment #28

Comment #29

News items

Our community

Documentation

Drupal code base

Governance of community