We should probably replace the breadcrumb separator with » to more closely match the current breadcrumb style in core. Attached patch does just that.

CommentFileSizeAuthor
#2 easy_breadcrumb-replace_separator-2938420-2.patch2.82 KBjenlampton

Comments

jenlampton created an issue. See original summary.

jenlampton’s picture

jenlampton
she / her
commented
Status: Active » Needs review
StatusFileSize
new easy_breadcrumb-replace_separator-2938420-2.patch2.82 KB
tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Status: Needs review » Needs work

Are we sure this character is the one that we need? :S Maybe » should be used as »'s html entity :/

tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Parent issue: » #2938503: New minor release of 7.x
jenlampton’s picture

jenlampton
she / her
commented
Status: Needs work » Needs review

Drupal uses UTF-8 for encoding all its data. It will be a better user experience if we show people the character we'll be using as the separator, rather than making them look up the HTML entity.

See the source code for theme_breadcrumb to see how core handles this character.

tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Status: Needs review » Reviewed & tested by the community

I've tested it on a fresh D7 using easy_breadcrumb 7.x-2.14 and it works well, thanks!
Furthermore, as theme_breadcrumb() uses the same character, i think it's a good improvement for the module to change it for the same - https://api.drupal.org/api/drupal/includes%21theme.inc/function/theme_br...

Bests,
Balazs.

renatog’s picture

renatog commented

works good for me too.

good catch

  • RenatoG committed e7e9718 on 7.x-2.x authored by jenlampton 
    Issue #2938420 by jenlampton, tatarbj, RenatoG: Replace the breadcrumb...
renatog’s picture

renatog commented
Status: Reviewed & tested by the community » Fixed

Fixed.

Committed to the dev branch: 7.x-2.x

Thank you very much.

Best,

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.