Closed (duplicate)
Project:
Drupal core
Version:
8.6.x-dev
Component:
Umami demo
Priority:
Major
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
19 Jan 2018 at 23:15 UTC
Updated:
5 Feb 2018 at 13:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
markconroy commentedsince this is a beta blocker, updating to major
Comment #3
markconroy commentedComment #4
markconroy commentedComment #5
markconroy commentedComment #6
andrewmacpherson commentedComment #7
markconroy commentedComment #8
markconroy commentedComment #9
David_Rothstein commentedI am not sure how to navigate the various sub-issues, but to kick off discussion I'm posting some patches on a few of them. Since the text in the various places is related to each other, I'm posting screenshots here for review as a group:
#2938800: Finalize wording for Toolbar warning message
Before it looked like this:

After it looks like this:

No big changes really, just tried to soften the text a bit. (Note: That issue seems to be about the design in addition to the wording? Or was there supposed to be a different issue for the toolbar wording, separate from the toolbar design?...)
Big issue: Clicking on this message still takes you to https://www.drupal.org/project/drupal/issues/2829101 - that doesn't make sense. Still needs work to figure out a good page to link to.
#2938803: Remove the warning about the Umami profile on the install screen
Before it looked like this:

After it looks like this:

This includes suggestions from #2822414-46: Redesign the 'install profile selection' installer screen to allow for experimental profiles and more information with a few additional refinements. Note that for the "warning" text, I deliberately made it roughly the same as the toolbar text above.
#2938805: Finalise the wording of the warning message on the status report page
The "before" behavior actually has a couple variations.
Regular:

If you've updated to a new version of Drupal core after installing the profile:

I do not really see a point in the latter, especially not in making it an "error" condition and the vague reference to "issues with this site". Updating to a new version of Drupal core just means that your demo site does not match what the latest-and-greatest demo site would be (if you were to reinstall from scratch) but that is not an error condition. I can see some logic for an informational message there (rather than an error), but for now, I removed it.
Therefore, after the patch it looks like this:

Note that I tried to make the wording/design of the "experimental profiles" section more closely match the one for "experimental modules".
Obviously, the screenshots also show that there is still a (preexisting) bug here with the HTML in the profile name being printed as escaped HTML on the status report...
Comment #10
markconroy commentedThe items in this are being taken care of in separate issues, so marking this a duplicate.