Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
This is a child issue of [META] Finalise the wording of the messages in installer, toolbar and on the status report page - #2938189: [META] Finalise the wording of the messages in installer, toolbar and on the status report page
We need to agree the final text that will be visible on the status report page to let users know about this being an experimental profile.
Proposed resolution
The "before" behavior actually has a couple variations.
Regular:
If you've updated to a new version of Drupal core after installing the profile:
Proposal by David_Rothstein in the meta issue:
Remaining tasks
- Decide the text
- Implement it
Comment | File | Size | Author |
---|---|---|---|
#14 | Screenshot_20180203-062455.png | 284.37 KB | Eli-T |
#11 | Status_report___drupal_8_6_x_umami_install.png | 185.79 KB | Eli-T |
#10 | interdiff-7-10.txt | 1.42 KB | markconroy |
#10 | 2938805-10.patch | 3.71 KB | markconroy |
#7 | interdiff-2-7.txt | 814 bytes | markconroy |
Comments
Comment #2
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedHere's a possible patch. See #2938189-9: [META] Finalise the wording of the messages in installer, toolbar and on the status report page for discussion and screenshots.
Comment #3
ckrinaComment #4
ckrinaAdding initiative tag.
Comment #5
ckrinaWe discussed this the UX meeting:
+1 to that from people attending the meeting.
+ 1 from some people in the meeting. It was said that "whatever Drupal Core does, it's not Umami's problem".
Comment #6
markconroy CreditAttribution: markconroy as a volunteer and at Annertech commentedSuggestion at today's weekly meeting was that the text change from
Experimental profiles are provided for testing purposes only. Use at your own risk. To start building a new site, reinstall Drupal and choose a different profile.
to
Experimental profiles are provided for testing purposes only. Use at your own risk. To start building a new site, reinstall Drupal and choose a non-experimental profile.
This got a +1 from the weekly meeting today.
Comment #7
markconroy CreditAttribution: markconroy as a volunteer and at Annertech commentedPatch attached that changes to content to what we agreed at the weekly meeting. I think the rest of the work by david_rothstein here is fine.
Comment #9
Eli-TIn core/profiles/demo_umami/demo_umami.install
drupal_get_profile() is deprecated - we should use \Drupal::installProfile() instead.
Also the test doesn't match the changed text.
demo_umami_requirements() outputs
'Experimental profiles are provided for testing purposes only. Use at your own risk. To start building a new site, reinstall Drupal and choose a non-experimental profile.'
'Experimental profiles are provided for testing purposes only. Use at your own risk. To start building a new site, reinstall Drupal and choose a different profile.'
Probably why it's failing.
Comment #10
markconroy CreditAttribution: markconroy as a volunteer and at Annertech commentedAdding changes from #10
Comment #11
Eli-TTested patch in #10 on SimplyTest.me
Status report shows
which is the agreed message.
A Standard install was performed with the same patch; these warnings were not shown.
Visual inspection of the deprecated code and test mismatch identified in #9 have been fixed.
Therefore this can be set to RTBC if the automated tests pass.
Comment #12
Eli-TComment #13
larowlanScreenshot at #11 shows escaped
<strong>
tagsComment #14
Eli-T@larowlan that is fixed in #2938185: When installing Umami, only show warning if 'Demo Umami' radio button is selected (and ensure that it is obvious that warning message only applies to the Umami profile)
Screenshot from the latest patch in that issue:
Therefore returning to RTBC
Comment #15
markconroy CreditAttribution: markconroy as a volunteer and at Annertech commentedYes, the name of the profile comes from the name on the installer screen which does not have the
<strong>
tags (when #2938185: When installing Umami, only show warning if 'Demo Umami' radio button is selected (and ensure that it is obvious that warning message only applies to the Umami profile) gets committed).Comment #16
ckrina+1 to RTBC
Comment #17
smazJust a thought, should we still store the version of Drupal that was installed so if in the future we need to bring back a warning / error about needing to re-install the demo, we can do so?
(would mean bringing back the \Drupal::state()->set('demo_umami_drupal_version', \Drupal::VERSION); part)
I don't think it would hurt to have that there for potential future use.
Comment #18
larowlan#17 sounds like there is still debate here.
On the basis of #13 feels like this should be postponed on #2938185: When installing Umami, only show warning if 'Demo Umami' radio button is selected (and ensure that it is obvious that warning message only applies to the Umami profile)
Comment #19
Eli-T@smaz wrt #17, I don't think we can justify speculatively storing data just in case we need it in the future. I certainly can't think of anywhere else we do that, but I'm happy to be corrected.
If we have a concrete use case for requiring that data in the future, it will be to check if the version number has changed since install. At that point we can store the version number and use logic like (excuse pseudocode)
Comment #20
Eli-TWhilst this issue does not introduce the strong tag referenced in #13, it is due to this issue that it is exposed on the status page. Therefore I agree this should be postponed until that has been removed in #2938185: When installing Umami, only show warning if 'Demo Umami' radio button is selected (and ensure that it is obvious that warning message only applies to the Umami profile).
Comment #21
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedThat's not true; as can be seen from the screenshots in the issue summary, the escaped
<strong>
tags already appear on the status report page before this patch. This patch does increase the number of places they appear on the status report from 1 to 2, but that doesn't seem like a good reason to postpone this.Regarding the idea of continuing to store the version of Drupal that was installed, I think the analysis in #19 is exactly correct. Also, if we did want to store this for hypothetical future purposes, I think a good argument could be made that Drupal core itself should be storing it (not the Umami profile) since other code out there could find it useful as well. So, separate issue, I think.
For those reasons, I am moving this issue back to RTBC.
Comment #23
larowlanThanks @DavidRothstein, I didn't realise that the escaped strong tags existed in HEAD.
Agree, this isn't making it worse.
Committed as 40af3f5 and pushed to 8.6.x