Follow up to https://www.drupal.org/project/drupal/issues/2809635#comment-12433667

CommentFileSizeAuthor
#6 2937894_2.patch519 bytesnavneet0693
#2 2937894_1.patch1.34 KBnavneet0693

Comments

navneet0693 created an issue. See original summary.

navneet0693’s picture

navneet0693 commented
Status: Active » Needs review
StatusFileSize
new 2937894_1.patch1.34 KB
navneet0693’s picture

navneet0693 commented
Title: Umami Profile - follow up - remove temp banner schema from demo_umami.schema.yml » Umami Profile - follow up - from #215 on 2809635
Issue summary: View changes
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Needs work 
+++ b/core/profiles/demo_umami/config/schema/demo_umami.schema.yml
@@ -25,7 +25,3 @@ block.settings.umami_footer_promo:
-block.settings.umami_recipes_banner_temp:
-  type: block_settings
-  label: 'Banner'

+++ b/core/profiles/demo_umami/themes/umami/umami.theme
@@ -63,7 +63,7 @@ function umami_preprocess_breadcrumb(&$variables) {
-  if ($route = $request->attributes->get(RouteObjectInterface::ROUTE_OBJECT)) {
+  if ($route = \Drupal::routeMatch()->getRouteObject()) {

We're fixing two things here, can we fix just the schema here, and open a new issue for the route match change.

navneet0693’s picture

navneet0693 commented
Title: Umami Profile - follow up - from #215 on 2809635 » Umami Profile - follow up - from #215 on 2809635 - remove temp banner schema from demo_umami.schema.yml
navneet0693’s picture

navneet0693 commented
Status: Needs work » Needs review
StatusFileSize
new 2937894_2.patch519 bytes
acbramley’s picture

acbramley commented
Status: Needs review » Reviewed & tested by the community

LGTM!

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Title: Umami Profile - follow up - from #215 on 2809635 - remove temp banner schema from demo_umami.schema.yml » Remove unneeded schema entry from demo_umami.schema.yml

  • larowlan committed c212be4 on 8.6.x 
    Issue #2937894 by navneet0693: Remove unneeded schema entry from...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed as c212be4 and pushed to 8.6.x. Thanks!

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Component: install system » Umami demo

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.