Hello!

I have a site in which we are using this module, it works great but we need to be able to enable popup not just per language, also per market, right now it isn't possible to add more conditions without hacking the module and it would be awesome if this could be part of the module.

CommentFileSizeAuthor
#3 eu_cookie_compliance-popup-configurable-by-other-modules-2937493-3-d7.patch1.58 KBsvenryen
#2 eu_cookie_compliance-popup-configurable-by-other-modules-2937493-2-d7.patch969 bytesdharizza
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dharizza created an issue. See original summary.

dharizza’s picture

dharizza CreditAttribution: dharizza at Manatí commented
FileSize
eu_cookie_compliance-popup-configurable-by-other-modules-2937493-2-d7.patch969 bytes

I'm adding a patch that adds a drupal_alter in the hook_page_build so other modules can implement hook_TYPE_alter and do their own logic there.

svenryen’s picture

svenryen CreditAttribution: svenryen at Ramsalt Lab commented
FileSize
eu_cookie_compliance-popup-configurable-by-other-modules-2937493-3-d7.patch1.58 KB

Thanks for the patch - nice one. I reviewed/tested and verified that it works.

For completeness, I added documentation in .api.php.

Here's the complete patch.

  • svenryen committed b2b084a on 7.x-1.x authored by dharizza 
    Issue #2937493 by dharizza, svenryen: Make 'Enable popup' configurable...
svenryen’s picture

svenryen CreditAttribution: svenryen at Ramsalt Lab commented
Status: Active » Fixed

  • svenryen committed aa984ad on 7.x-2.x 
    Merge branch '7.x-1.x' into 7.x-2.x

* 7.x-1.x: (76 commits)
Fixed an...
  • svenryen committed b2b084a on 7.x-2.x authored by dharizza
    Issue #2937493 by dharizza, svenryen: Make 'Enable popup' configurable...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.