Closed (fixed)
Project:
Thunder
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Jan 2018 at 10:13 UTC
Updated:
21 Jun 2018 at 13:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
stborchertPull request: https://github.com/BurdaMagazinOrg/thunder-distribution/pull/480
Comment #3
stborchertComment #4
mtodor commentedCopy from GitHub PR
@stBorchert Thank you for reporting problem.
I'm not sure this is correct way to solve this problem. Ignoring some parts of configuration updates could lead to incorrect behaviour of introduced functionality or made changes. Currently we have extensive logging of failed configuration updates and with this change they are silently ignored.
Also we want to have one module where all configuration updates and update hooks will be collected. That means thunder_update_8112() hook has wrong approach.
I can't propose solution like this for following problem, it should not ever happen that update hook is executed and required configuration update definition files are not available for it. I would rather move all configuration update files into profile, where update hook is.
Comment #5
mtodor commented@stBorchert
I have made other PR for this problem: https://github.com/BurdaMagazinOrg/thunder-distribution/pull/525
Can you please take a look and test?
As I have explained the problem is not in Updater functionality, but the wrong approach in update hook, where update hook relies on un-available resources.
Comment #7
mtodor commentedComment #8
mtodor commentedCrediting for review.
Comment #10
mtodor commented