Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
16 Jan 2018 at 22:01 UTC
Updated:
4 Mar 2020 at 11:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
thihathit commentedComment #3
thihathit commentedComment #4
raushan commentedHi,
Please fix below errors in your module :
1. Please use elseif in place of multiple If condition on line 49 to 57 in module file.
2. Add hook_help() in module file.
3. Add more description in admin UI for better understating.
4. Remove automated testing errors. please check here https://pareview.sh/pareview/https-git.drupal.org-project-block_cache.git
Thanks
Comment #5
avpadernoComment #6
avpadernoIf you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.
I am closing this application due to lack of activity.
Comment #7
thihathit commentedHi,
I've fixed the coding standard errors, though it's been a while,
https://pareview.sh/pareview/https-git.drupal.org-project-block_cache.git
Comment #8
rksyraviHi @thihathit,
Thank you for your contribution.
everything looks good except the hook_help().
Comment #9
rksyraviComment #10
avpadernoThe absence of
hook_help()is not a reason to change status, given that it is going to be replaced.Comment #11
thihathit commentedCurrentlyFixedhook_help()is implemented in .module, Is it required to be replace with newer hook ?hook_help()Comment #12
rksyraviHi @thihathit,
No more blocker left.
I just wanted to ask you, does this module disable the cache of anonymous users too.
Comment #13
crafter commentedHi, does it support system block as well? As far as I see that it's only work for custom block created by ui, but what about others system and programming block?
Comment #14
thihathit commentedHi @crafter, It works on any blocks that pass through
hook_block_build_alter()since this module alters the cache settings from hook_block_build_alter() so it works including Views.But there's an exception, if the block has
Twigfield(e.g: in combination with Twig text filter), It won't work on that field because it is controlled by Drupal's twig cache.@rksyravi, Haven't tested for sure but it should work theoretically. If it doesn't, might need to make feature request for
hook_block_build_alter().Comment #15
thihathit commentedComment #16
thihathit commentedComment #17
ankush_03@thihathit,
As per comment #12 by @rksyravi
Yes, it is not working for anonymous users, kindly test with anonymous users and I have already tried to bypass block cache for anonymous users in my recent projects but I didn't get any solution.
Let me know your thought for the same.
Comment #18
avpadernoComment #19
avpadernoComment #20
thihathit commented@ankushgautam76@gmail.com, Thank you for testing.
Yes, It turns out not working due to Core's bug related to issues below.
https://www.drupal.org/node/2352009
https://www.drupal.org/node/2835068
Drupal 8 seems to use whole page caching mechanism just like Drupal 7, Unless caching is done using modular caching with block by block caching mechanism instead of whole page, there's no other solution except to disable the caching on the page where a block using this module's feature exists.
So, I've decided to;
I'll then obsolete the new option when Core's cache mechanism has been resolved.
Comment #21
thihathit commentedNew option is committed.
Feedback is appreciated.
Comment #22
thihathit commentedComment #23
klausiThanks for your contribution! Code looks good to me, did not see any security issues.
Comment #24
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #25
thihathit commentedThank you @kiamlaluno. And everyone for your kind reviews.
Comment #26
avpaderno