Closed (fixed)
Project:
Geolocation Field
Version:
8.x-2.x-dev
Component:
Geolocation Field / Backend
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 Jan 2018 at 14:20 UTC
Updated:
11 Mar 2019 at 09:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
piridium commentedComment #3
piridium commentedComment #5
piridium commentedNew patch with corrected filename in first line.
Comment #6
piridium commentedComment #8
piridium commentedSorry, it seems that I am unable to create a patch which passes automated testing. Any help is appreciated.
Comment #9
christianadamski commented@piridium, patch has to relative to project root. The usual method is to checkout the git repository and simply do a "git diff > patchfile.patch".
I plan to rework this whole addressing part in 2.x in a different way. I might commit this to v1 though. Just have to find the time.
Comment #10
MaskOta commentedI don't know if this helps you but try looking at the address module and their libraries to deal with addressing. No reason to solve these complex problems more than once
https://www.drupal.org/project/address
https://github.com/commerceguys/addressing
Comment #11
primsi commentedHaving a more general solution would be sure nicer, but just re-rolling for now.
Comment #12
christianadamski commentedWill be fixed in 2.x
Comment #14
christianadamski commentedCommitted to 1.x and fixed in 2.x