Following errors are reported on phpcs when I run the module.


FILE: /var/www/html/drupal-8.4.3/modules/consumers/consumers.install
----------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------
 15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found
    |       |     4
 16 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
    |       |     6
 21 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
    |       |     6
 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found
    |       |     4
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: .../www/html/drupal-8.4.3/modules/consumers/src/Entity/Consumer.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 149 | ERROR | [x] Array indentation error, expected 8 spaces but
     |       |     found 9
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
CommentFileSizeAuthor
#4 code_review_changes-2936316-4.patch267 bytessivaprasadc
#2 code_review_changes-2936316-2.patch1.19 KBvenkatesh rajan.j

Comments

Venkatesh Rajan.J created an issue. See original summary.

venkatesh rajan.j’s picture

venkatesh rajan.j commented
Status: Active » Needs review
StatusFileSize
new code_review_changes-2936316-2.patch1.19 KB

The attached patch will fix the above-reported errors.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs review » Fixed

This was fixed. Thanks for the contribution.

Please make sure to also do meaningful contributions to modules, other than running phpcbf automatically. Gaming the credit system is creating an unfair load on project maintainers.

Thanks again.

sivaprasadc’s picture

sivaprasadc commented
Status: Fixed » Needs review
StatusFileSize
new code_review_changes-2936316-4.patch267 bytes

@e0ipso

When I run phpcs, still one more warning is there.

All dependencies must be prefixed with the project name, for example "drupal:".

Please find the attached patch file.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented

@Sivaprasad C can you please post the complete phpcs command you're running?

sivaprasadc’s picture

sivaprasadc commented

@e0ipso 

 phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md {path}/consumers/
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented

@Sivaprasad C are you using this module?

sivaprasadc’s picture

sivaprasadc commented

yes.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.