Closed (fixed)
Project:
Google Authenticator login
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
12 Jan 2018 at 15:12 UTC
Updated:
30 Jan 2018 at 16:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
daggerhart commentedTests were failing because the attempts to find the login_hash from the current url were unsuccessful.
This patch fixes those attempts and moves the finding of the login_hash to a function on the base test class to stay dry.
Comment #3
daggerhart commentedAnother attempt. Removing hard-coded module version from info file to see if that helps tests run on d.o
Comment #4
daggerhart commentedRemoving patch that deals with the info file, restoring original patch.
Comment #5
daggerhart commentedAnother attempt at fixing tests. Added @group GA_Login to test base class.
Comment #7
daggerhart commentedAdding @group was incorrect. Doing so made the system attempt to load
GALoginTestBaseas if it had tests, but it is a base class meant to be extended. I examined some core modules and found that they use abstract base classes so that the system wouldn't look for tests on that class.I expect this patch to fail 2 tests involving exceptions around
$siteNamePrefixbeing undefined. These tests should be fixed when #2871779: Allow the configuration of the QR pattern prefix gets committed, as it adds that property to the test objects.After posting this comment and letting the tests run, I'll mark this issue as postponed until we get #2871779 committed. Then we should be able to re-queue this test and have it pass.
Comment #9
daggerhart commentedPostponed until #2871779: Allow the configuration of the QR pattern prefix lands for simplicity.
Comment #10
daggerhart commentedTests are running and all passing.
Comment #11
nerdsteinThe review of the patch looks good and the testbot demonstrates the tests are now successfully running. I'm merging this and marking as fixed. Thank you!