Currently tests are not being detected on the 8.x branch of this module. When patches are submitted to issues they always result in "No tests found". Additionally some tests run locally are failing.

Comments

daggerhart created an issue. See original summary.

daggerhart’s picture

Status: Active » Needs review
StatusFileSize
new5.54 KB

Tests were failing because the attempts to find the login_hash from the current url were unsuccessful.

This patch fixes those attempts and moves the finding of the login_hash to a function on the base test class to stay dry.

daggerhart’s picture

StatusFileSize
new5.92 KB

Another attempt. Removing hard-coded module version from info file to see if that helps tests run on d.o

daggerhart’s picture

Removing patch that deals with the info file, restoring original patch.

daggerhart’s picture

StatusFileSize
new5.71 KB

Another attempt at fixing tests. Added @group GA_Login to test base class.

Status: Needs review » Needs work

The last submitted patch, 5: 2936247-4-fix-tests.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

daggerhart’s picture

Status: Needs work » Needs review
StatusFileSize
new5.87 KB

Adding @group was incorrect. Doing so made the system attempt to load GALoginTestBase as if it had tests, but it is a base class meant to be extended. I examined some core modules and found that they use abstract base classes so that the system wouldn't look for tests on that class.

I expect this patch to fail 2 tests involving exceptions around $siteNamePrefix being undefined. These tests should be fixed when #2871779: Allow the configuration of the QR pattern prefix gets committed, as it adds that property to the test objects.

After posting this comment and letting the tests run, I'll mark this issue as postponed until we get #2871779 committed. Then we should be able to re-queue this test and have it pass.

Status: Needs review » Needs work

The last submitted patch, 7: 2936247-7-fix-tests.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

daggerhart’s picture

Status: Needs work » Postponed
daggerhart’s picture

Status: Postponed » Needs review

Tests are running and all passing.

nerdstein’s picture

Status: Needs review » Fixed

The review of the patch looks good and the testbot demonstrates the tests are now successfully running. I'm merging this and marking as fixed. Thank you!

  • nerdstein committed 06f1179 on 8.x-1.x authored by daggerhart
    Issue #2936247 by daggerhart: Fix testing runs on d.o and ensure all...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.