CommentFileSizeAuthor
#3 Before_Social.png66.15 KBriddhi.addweb
#3 After_Social.png58.35 KBriddhi.addweb
#2 D8-dependencies-2935848.patch412 bytessaravanaprasanth

Comments

saravanaprasanth created an issue. See original summary.

saravanaprasanth’s picture

saravanaprasanth commented
StatusFileSize
new D8-dependencies-2935848.patch412 bytes
riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new After_Social.png58.35 KB
new Before_Social.png66.15 KB

@saravanaprasanth, Thanks for the patch, your patch corrects the warning error as per standard. Also, I verify it using Pareview.sh & also checked after before result verification with simplytest.me. PFA screenshots.

gvso’s picture

gvso
Primary language Spanish
commented
Status: Reviewed & tested by the community » Needs work

Why is this required? Aren't all the dependencies declared in .info.yml from Drupal? Any link that can help me understand will be appreciated.

saravanaprasanth’s picture

saravanaprasanth commented

Hi gvso,

Please refer the following links.

https://www.drupal.org/project/xmlsitemap/issues/2907577
https://www.drupal.org/project/colorbox_inline/issues/2890408
https://www.drupal.org/project/admin_toolbar/issues/2927905

gvso’s picture

gvso
Primary language Spanish
commented
Title: All dependencies must be prefixed with the project name, for example "drupal:" » Fix dependency declaration

Also, we need to specify the Social Auth version, so I will include that in this commit

  • gvso committed b334eb7 on 8.x-2.x authored by saravanaprasanth 
    Issue #2935848 by saravanaprasanth, Jigar.addweb, gvso: Fix dependency...
gvso’s picture

gvso
Primary language Spanish
commented
Status: Needs work » Fixed

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

gvso’s picture

gvso
Primary language Spanish
commented
Status: Closed (fixed) » Needs work

This commit created the following issue #2950061: not possible to update social_post with composer (and so for social_post_twitter)

  • gvso committed b5d2ffb on 8.x-2.x 
    Issue #2935848 by jeanseb.valette: Fix dependency declaration

gvso credited jeanseb.valette.

gvso’s picture

gvso
Primary language Spanish
commented
Status: Needs work » Fixed
jeanseb.valette’s picture

jeanseb.valette commented

Fix Work fine.
thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.