Add support for new Off-Canvas dialog tray [#2935697]

Comment	File	Size	Author
#13	2935697-13.patch	42.2 KB	jrockowitz
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.4 684 pass
#7	2935697-7.patch	41.61 KB	jrockowitz
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.4 683 pass, 1 fail
#2	2935697-2.patch	4.05 KB	jrockowitz
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.4 684 pass

Comment #1

10 January 2018 at 16:17

jrockowitz created an issue. See original summary.

Log in or register to post comments

File	Size
2935697-2.patch	4.05 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.4 684 pass

File	Size
2935697-7.patch	41.61 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.4 683 pass, 1 fail

Comment #10

11 January 2018 at 02:18

Status:

Needs review

» Needs work

The last submitted patch, 7: 2935697-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Log in or register to post comments

File	Size
2935697-13.patch	42.2 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.4 684 pass

Comment #16

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 11 January 2018 at 18:55

Status:

Needs review

» Fixed

Log in or register to post comments

Comment #17

25 January 2018 at 18:59

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Log in or register to post comments

Comment #18

tedbow

he/him

English

Ithaca, NY, USA

CreditAttribution: tedbow at Acquia commented 4 February 2018 at 20:46

+++ /dev/null
@@ -1,32 +0,0 @@
diff --git a/modules/webform_ui/webform_ui.links.contextual.yml b/modules/webform_ui/webform_ui.links.contextual.yml

diff --git a/modules/webform_ui/webform_ui.links.contextual.yml b/modules/webform_ui/webform_ui.links.contextual.yml
deleted file mode 100644

deleted file mode 100644
index 13ea3bf1..00000000

index 13ea3bf1..00000000
--- a/modules/webform_ui/webform_ui.links.contextual.yml

--- a/modules/webform_ui/webform_ui.links.contextual.yml
+++ /dev/null

+++ /dev/null
+++ /dev/null
@@ -1,4 +0,0 @@

@@ -1,4 +0,0 @@
-entity.webform.quickedit:
-  title: 'Quick Edit'
-  route_name: entity.webform.edit_form
-  group: webform

@jrockowitz was deleting this intentional?

I think it removes the "Quick Edit" link when view a webform.

Log in or register to post comments

Comment #19

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 4 February 2018 at 22:00

@tedbow I removed the quickedit link because the system tray's CSS reset was making the edit element form unusable. For example, the edit element form relies on Select2 and the CSS reset was completely resetting all the Select2 element's CSS. For now, I am just using the system tray via the admin UI/UX without the CSS reset. This was tricky decision but most admin theme's system tray looks okay without the CSS reset.