Problem/Motivation

New Off-Canvas dialog tray now available

Proposed resolution

Add support for new Off-Canvas dialog tray

Remaining tasks

  • Fix old off-canvas implementation
  • Determine how to fix CSS reset issue

Notes

  • Only supporting 8.5.x
  • Off canvas tray is using a complete CSS reset which is going to cause styling issue.

User interface changes

TBD

CommentFileSizeAuthor
#13 2935697-13.patch42.2 KBjrockowitz
#7 2935697-7.patch41.61 KBjrockowitz
#2 2935697-2.patch4.05 KBjrockowitz

Comments

jrockowitz created an issue. See original summary.

jrockowitz’s picture

jrockowitz commented
Status: Active » Needs review
StatusFileSize
new 2935697-2.patch4.05 KB

  • jrockowitz committed 5b6ce72 on 2935697-off-canvas-support 
    Issue #2935697 by jrockowitz: Add support for new Off-Canvas dialog tray

  • jrockowitz committed 9d5ad6a on 2935697-off-canvas-support 
    Issue #2935697 by jrockowitz: Add support for new Off-Canvas dialog tray

  • jrockowitz committed 12f4d8f on 2935697-off-canvas-support 
    Issue #2935697 by jrockowitz: Add support for new Off-Canvas dialog tray...

  • jrockowitz committed 54c2259 on 2935697-off-canvas-support 
    Issue #2935697 by jrockowitz: Add support for new Off-Canvas dialog tray...
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 2935697-7.patch41.61 KB

  • jrockowitz committed bd3b7a9 on 2935697-off-canvas-support 
    Issue #2935697 by jrockowitz: Add support for new Off-Canvas dialog tray...

  • jrockowitz committed 1590e3e on 2935697-off-canvas-support 
    Issue #2935697 by jrockowitz: Add support for new Off-Canvas dialog tray...

Status: Needs review » Needs work

The last submitted patch, 7: 2935697-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • jrockowitz committed 42f13cf on 2935697-off-canvas-support 
    Issue #2935697 by jrockowitz: Add support for new Off-Canvas dialog tray...

  • jrockowitz committed e970a0d on 2935697-off-canvas-support 
    Issue #2935697 by jrockowitz: Add support for new Off-Canvas dialog tray...
jrockowitz’s picture

jrockowitz commented
Status: Needs work » Needs review
StatusFileSize
new 2935697-13.patch42.2 KB

  • jrockowitz committed 343f94f on 2935697-off-canvas-support 
    Issue #2935697 by jrockowitz: Add support for new Off-Canvas dialog tray...

  • jrockowitz committed 112ad1a on 8.x-5.x 
    Issue #2935697 by jrockowitz: Add support for new Off-Canvas dialog tray
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented 
+++ /dev/null
@@ -1,32 +0,0 @@
diff --git a/modules/webform_ui/webform_ui.links.contextual.yml b/modules/webform_ui/webform_ui.links.contextual.yml

diff --git a/modules/webform_ui/webform_ui.links.contextual.yml b/modules/webform_ui/webform_ui.links.contextual.yml
deleted file mode 100644

deleted file mode 100644
index 13ea3bf1..00000000

index 13ea3bf1..00000000
--- a/modules/webform_ui/webform_ui.links.contextual.yml

--- a/modules/webform_ui/webform_ui.links.contextual.yml
+++ /dev/null

+++ /dev/null
+++ /dev/null
@@ -1,4 +0,0 @@

@@ -1,4 +0,0 @@
-entity.webform.quickedit:
-  title: 'Quick Edit'
-  route_name: entity.webform.edit_form
-  group: webform

@jrockowitz was deleting this intentional?

I think it removes the "Quick Edit" link when view a webform.

jrockowitz’s picture

jrockowitz commented

@tedbow I removed the quickedit link because the system tray's CSS reset was making the edit element form unusable. For example, the edit element form relies on Select2 and the CSS reset was completely resetting all the Select2 element's CSS. For now, I am just using the system tray via the admin UI/UX without the CSS reset. This was tricky decision but most admin theme's system tray looks okay without the CSS reset.