Remove all usages of drupal_get_message and drupal_set_message in modules

Patch applies cleanly. The requirements needed are satisfied.

Patch applies cleanly. The requirements needed are satisfied.

grep -inr -e "drupal_set_message" -e "drupal_set_message" core/modules/[a-f]*
core/modules/big_pipe/src/Render/BigPipe.php:733:    // change the way drupal_set_message() works in the Drupal 8 cycle. So we
core/modules/block/tests/modules/block_test/src/Controller/TestMultipleFormController.php:20:    // Output all attached placeholders trough drupal_set_message(), so we can
core/modules/content_moderation/src/Plugin/Action/ModerationOptOutPublish.php:77:      drupal_set_message($this->t("@bundle @label were skipped as they are under moderation and may not be directly published.", ['@bundle' => $bundle_label, '@label' => $entity->getEntityType()->getPluralLabel()]), 'warning');
core/modules/content_moderation/src/Plugin/Action/ModerationOptOutUnpublish.php:77:      drupal_set_message($this->t("@bundle @label were skipped as they are under moderation and may not be directly unpublished.", ['@bundle' => $bundle_label, '@label' => $entity->getEntityType()->getPluralLabel()]), 'warning');
core/modules/file/file.module:1013:      // @todo Add support for render arrays in drupal_set_message()? See

#2942068: FileTestSaveUploadFromForm incorrectly counts messages already in core

Rerolled regarding last changes.
core/modules/file/tests/file_test/src/Form/FileTestSaveUploadFromForm.php - calls already replaced. Removed changes from the patch.
core/modules/content_moderation/src/EntityTypeInfo.php - content moderation changes had removed single usage of DSM. So, removed changes from the patch for this file.
core/modules/field/tests/modules/field_test/field_test.module - rerolled regarding #2940201: hook_field_widget_form_alter() can no longer affect the whole widget for multi-value fields

Thank's @kim.pepper for review.
Added missing replacements.

Please combine the patches in #2935258: Remove all usages of drupal_get_message and drupal_set_message in modules M-R and #2935259: Remove all usages of drupal_get_message and drupal_set_message in modules S-Z into this one so all the module changes can be reviewed together. I think it's fine to do core/lib separately.

@catch - i will combine all three patches

@catch - I have combined all three patches & removed the core/lib separately as mentioned in #24 but i think few usages #2935257: [PP-1] Remove all usages of drupal_get_message and drupal_set_message in modules G-L are still there.

As discussed with @catch, here is the latest updated patch to remove all usage of drupal_get_message & drupal_set_message in modules, only two occurrences left when we check with grep -inr -e "drupal_set_message" -e "drupal_get_message" core/modules/* as mentioned in #16.
Hopefully it pass all the test cases.

Oops.

Cleanup after reroll in #33.

@Girish-jerk hasn't touched this for 3 weeks so I'll have a go.

Corrected the failing test (after a minor re-roll).

Resolved the issue that @kim.pepper raised in #39.

A quick search suggests there are plenty of instances of drupal_set_message() remaining in the codebase (e.g. Drupal\Core\Form\EventSubscriber\FormAjaxSubscriber::drupalSetMessage) - do any of these have reason to remain? I'm fast going off this ticket!

I guess this method should not be removed for now. Maybe better mark that method internal or deprecated?

Update tests to reflect removal of drupalSetMessage().

#44: +1

Corrected the nit from #44.

Let's push this one across the line and forget this huge patch forever!

+1 for RTBC

Crediting @jibran and @catch for reviewing this and the other patches that have been merged into this one.

Committed b84b827 and pushed to 8.6.x. Thanks!

This broke PHP 5.5 testing. I hotfixed because it is the 8.6.x branch and committing this patch once is enough disruption.