Thanks for continuing to work on this helpful module!
Since auto entity label tabs exist on content types, I'm confused why there's a page called "Automatic label" under the "Structure" menu. This seems like duplication.
If there is a reason for it to be there, then:
1. It would be nice if it were alphabetized with everything else, instead of forcing it to the very bottom of the list.
2. It would be nice if the help text on this page wasn't FORCED INTO ALL CAPS. I'm not sure why that's being done, but it's clearly intentional -- here're the relevant lines from AutoEntityLabelController.php:
$markup .= '<li><a href="/admin/structure/types/manage/' . $content_type_machine_name . '/auto-label"><span class="label">' . $content_type_label . '</span><div class="description">AUTOMATIC LABEL GENERATION FOR ' . strtoupper($content_type_label) . '</div></a></li>';
}
I put this under UI because it's clearly not a critical code issue or anything, but I do find it confusing (and therefore a bug) from a usability perspective. Unless there's something I'm missing?
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 2935247-3.auto_entitylabel.remove-global-settings-page.patch | 5.24 KB | dww |
Comments
Comment #2
dwwFurthermore, the links are all broken if Drupal is installed in a subdir.
This whole page seems rather broken and confusing. I'd be in favor of ripping it out entirely.
Comment #3
dwwAnd, the page only gives you (broken) links to auto_entitylabel configuration for node types, but the whole point of this module is that it's general and lets you configure labels for other entity types (e.g. media). Yeah, let's kill this page. It's bloated code, doesn't work properly, and gives the false impression that this module only lets you configure labels for node types.
I ripped out the page and modified the help text that pointed to it. Nice simplification since we no longer need src/Controller/AutoEntityLabelController.php, auto_entitylabel.links.menu.yml nor auto_entitylabel.routing.yml.
Comment #4
dwwComment #5
rootworkPatch applies and looks great. Thanks @dww!
Comment #6
renatog commentedI check and really makes sense.
P.s. We just need update "configure" key in info file yml but the patch works good.
Thank you very much @dww.
Comment #8
renatog commentedCommitted to the dev branch.
Thank you for your contributions @dww
Thank you for review rootwork.
Good Work.
Best,
Comment #9
dwwThanks for catching the configure key in the .info.yml file!
Obrigado,
-Derek