Thanks for continuing to work on this helpful module!

Since auto entity label tabs exist on content types, I'm confused why there's a page called "Automatic label" under the "Structure" menu. This seems like duplication.

If there is a reason for it to be there, then:

1. It would be nice if it were alphabetized with everything else, instead of forcing it to the very bottom of the list.

2. It would be nice if the help text on this page wasn't FORCED INTO ALL CAPS. I'm not sure why that's being done, but it's clearly intentional -- here're the relevant lines from AutoEntityLabelController.php:

    $markup .= '<li><a href="/admin/structure/types/manage/' . $content_type_machine_name . '/auto-label"><span class="label">' . $content_type_label . '</span><div class="description">AUTOMATIC LABEL GENERATION FOR ' . strtoupper($content_type_label) . '</div></a></li>';
    }

I put this under UI because it's clearly not a critical code issue or anything, but I do find it confusing (and therefore a bug) from a usability perspective. Unless there's something I'm missing?

Comments

rootwork created an issue. See original summary.

dww’s picture

Furthermore, the links are all broken if Drupal is installed in a subdir.

This whole page seems rather broken and confusing. I'd be in favor of ripping it out entirely.

dww’s picture

Assigned: Unassigned » dww
Status: Active » Needs review
StatusFileSize
new5.24 KB

And, the page only gives you (broken) links to auto_entitylabel configuration for node types, but the whole point of this module is that it's general and lets you configure labels for other entity types (e.g. media). Yeah, let's kill this page. It's bloated code, doesn't work properly, and gives the false impression that this module only lets you configure labels for node types.

I ripped out the page and modified the help text that pointed to it. Nice simplification since we no longer need src/Controller/AutoEntityLabelController.php, auto_entitylabel.links.menu.yml nor auto_entitylabel.routing.yml.

dww’s picture

Title: Why does the 'Automatic label' form exist within Structure? » Remove the (broken and misleading) 'Automatic label' configuration page at /admin/structure/auto-label
rootwork’s picture

Status: Needs review » Reviewed & tested by the community

Patch applies and looks great. Thanks @dww!

renatog’s picture

I check and really makes sense.

P.s. We just need update "configure" key in info file yml but the patch works good.

Thank you very much @dww.

  • RenatoG committed 241c22e on 8.x-2.x authored by dww
    Issue #2935247 by dww, rootwork, RenatoG: Remove the (broken and...
renatog’s picture

Status: Reviewed & tested by the community » Fixed

Committed to the dev branch.

Thank you for your contributions @dww

Thank you for review rootwork.

Good Work.

Best,

dww’s picture

Thanks for catching the configure key in the .info.yml file!

Obrigado,
-Derek

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.