After running coding standards test on Paraview the following warnings appears:

FILE: /root/repos/pareviewsh/pareview_temp/mail_login.module
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
24 | WARNING | Line exceeds 80 characters; contains 82 characters
26 | WARNING | Only string literals should be passed to t() where
| | possible
27 | WARNING | Only string literals should be passed to t() where
| | possible
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/mail_login.install
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------
11 | ERROR | [x] You must use "/**" style comments for a function
| | comment
11 | ERROR | [x] Expected 1 blank line before function; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/README.txt
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
15 | WARNING | Line exceeds 80 characters; contains 84 characters
47 | WARNING | Line exceeds 80 characters; contains 104 characters
49 | WARNING | Line exceeds 80 characters; contains 101 characters
----------------------------------------------------------------------

FILE: ...pos/pareviewsh/pareview_temp/src/Form/MailLoginAdminSettingsForm.php
--------------------------------------------------------------------------
FOUND 15 ERRORS AND 1 WARNING AFFECTING 16 LINES
--------------------------------------------------------------------------
33 | ERROR | [x] Short array syntax must be used to define arrays
39 | ERROR | [x] Short array syntax must be used to define arrays
46 | ERROR | [x] Short array syntax must be used to define arrays
53 | ERROR | [x] Short array syntax must be used to define arrays
57 | ERROR | [x] Short array syntax must be used to define arrays
58 | ERROR | [x] Short array syntax must be used to define arrays
59 | ERROR | [x] Short array syntax must be used to define arrays
61 | ERROR | [x] Short array syntax must be used to define arrays
62 | ERROR | [x] Short array syntax must be used to define arrays
68 | ERROR | [x] Short array syntax must be used to define arrays
72 | ERROR | [x] Short array syntax must be used to define arrays
73 | ERROR | [x] Short array syntax must be used to define arrays
74 | ERROR | [x] Short array syntax must be used to define arrays
76 | ERROR | [x] Short array syntax must be used to define arrays
77 | ERROR | [x] Short array syntax must be used to define arrays
89 | WARNING | [ ] Possible useless method overriding detected
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY

Comments

Anas_maw created an issue. See original summary.

mqanneh’s picture

Assigned: Unassigned » mqanneh

  • mqanneh committed 4c6a313 on 8.x-1.x
    Issue #2934874 by Anas_maw, mqanneh: Following code standards
    
mqanneh’s picture

Assigned: mqanneh » Unassigned
Status: Active » Fixed

Fixed all errors reported in PAReview report.

mqanneh’s picture

Status: Fixed » Closed (fixed)
mqanneh’s picture

Issue summary: View changes