The "Common Admin username" test in acquia_spi.module (acquia_spi_get_super_name()) just tests for the presence of the strings "admin" and "root", which is overly simplistic. It complains, for example, about admin-dedd3e56a686, which I think is sufficiently difficult to guess. To ban those strings is to prevent site owners from capturing the business significance of the user in its name, which seems like an unnecessary concession. I suggest the test be sophisticated–perhaps to require a certain length or a number of bits of entropy or something if a username contains one of the blacklisted strings.

Comments

TravisCarden created an issue. See original summary.

traviscarden’s picture

Status: Active » Needs review
StatusFileSize
new614 bytes

Here's a simple patch that adds the condition that a username that contains the strings "admin" or "root" also be fewer than 15 characters in length before being considered "common".

traviscarden’s picture

Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

danepowell’s picture

CHAR_LENGTH is not valid for sqlite so this doesn't run in ORCA. I'll be changing this to LENGTH which I think will have the same effect?