Feature Request: To enhance look 7 feel of the Widget.
Description: Field available under Configuration 'Timestamp Field Description' produce output for the field can be used as Placeholder instead of Description.
Attached sample screenshot.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | Beforepatchapply.png | 12.93 KB | riddhi.addweb |
| #4 | unix_timestamp_conversion-review-3.jpg | 10.28 KB | jvogt |
| #4 | unix_timestamp_conversion-2933928-4-timestamp-placeholder.patch | 634 bytes | jvogt |
| #3 | 2933928-3.patch | 570 bytes | mahipal46 |
| 1.png | 6.55 KB | xaiwant |
Comments
Comment #2
mahipal46 commentedComment #3
mahipal46 commentedApplying the patch, please review
Comment #4
jvogt commentedmahipal46's (#3) patch works as intended, but removes the t() function, which is important for translation and sanitization. This version of the patch includes the t() again.
Also attached is a screenshot of the successful review of mahipal46's patch.
Comment #5
riddhi.addweb commented@zorya, Thanks for providing patch, Your patch corrects the required summary change, I checked it using simplytest.me & attached screenshot for the same.
Comment #6
dishabhadra commentedI reviewed the patch.
If you see the module, the description is a configurable field "admin/config/regional/unix-time-conversion/settings". And it looks like patch won't cover the use case when the description is configured as a long text.
Ex,
Long text like this won't look good as a placeholder due to which I think we should keep description as it is displayed presently.
Comment #7
dishabhadra commentedComment #8
dishabhadra commentedI am closing this request.