Feature Request: To enhance look 7 feel of the Widget.

Description: Field available under Configuration 'Timestamp Field Description' produce output for the field can be used as Placeholder instead of Description.

Attached sample screenshot.

Comments

xaiwant created an issue. See original summary.

mahipal46’s picture

Assigned: Unassigned » mahipal46
mahipal46’s picture

Status: Active » Needs review
StatusFileSize
new570 bytes

Applying the patch, please review

jvogt’s picture

mahipal46's (#3) patch works as intended, but removes the t() function, which is important for translation and sanitization. This version of the patch includes the t() again.

Also attached is a screenshot of the successful review of mahipal46's patch.

riddhi.addweb’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new12.93 KB

@zorya, Thanks for providing patch, Your patch corrects the required summary change, I checked it using simplytest.me & attached screenshot for the same.

dishabhadra’s picture

I reviewed the patch.

If you see the module, the description is a configurable field "admin/config/regional/unix-time-conversion/settings". And it looks like patch won't cover the use case when the description is configured as a long text.

Ex,

Ex: 1467504000 Lorem ipsum Lorem ipsum Lorem ipsum Lorem ipsum Lorem ipsum Lorem ipsum Lorem ipsum

Long text like this won't look good as a placeholder due to which I think we should keep description as it is displayed presently.

dishabhadra’s picture

Status: Reviewed & tested by the community » Needs review
dishabhadra’s picture

Assigned: mahipal46 » Unassigned
Status: Needs review » Closed (works as designed)

I am closing this request.