Feature Request: To enhance look 7 feel of the Widget.

Description: Field available under Configuration 'Timestamp Field Description' produce output for the field can be used as Placeholder instead of Description.

Attached sample screenshot.

CommentFileSizeAuthor
#5 Beforepatchapply.png12.93 KBriddhi.addweb
#4 unix_timestamp_conversion-review-3.jpg10.28 KBjvogt
#4 unix_timestamp_conversion-2933928-4-timestamp-placeholder.patch634 bytesjvogt
#3 2933928-3.patch570 bytesmahipal46
1.png6.55 KBxaiwant

Comments

xaiwant created an issue. See original summary.

mahipal46’s picture

mahipal46 commented
Assigned: Unassigned » mahipal46
mahipal46’s picture

mahipal46 commented
Status: Active » Needs review
StatusFileSize
new 2933928-3.patch570 bytes

Applying the patch, please review

jvogt’s picture

jvogt commented
StatusFileSize
new unix_timestamp_conversion-2933928-4-timestamp-placeholder.patch634 bytes
new unix_timestamp_conversion-review-3.jpg10.28 KB

mahipal46's (#3) patch works as intended, but removes the t() function, which is important for translation and sanitization. This version of the patch includes the t() again.

Also attached is a screenshot of the successful review of mahipal46's patch.

riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Beforepatchapply.png12.93 KB

@zorya, Thanks for providing patch, Your patch corrects the required summary change, I checked it using simplytest.me & attached screenshot for the same.

dishabhadra’s picture

dishabhadra commented

I reviewed the patch.

If you see the module, the description is a configurable field "admin/config/regional/unix-time-conversion/settings". And it looks like patch won't cover the use case when the description is configured as a long text.

Ex,

Ex: 1467504000 Lorem ipsum Lorem ipsum Lorem ipsum Lorem ipsum Lorem ipsum Lorem ipsum Lorem ipsum

Long text like this won't look good as a placeholder due to which I think we should keep description as it is displayed presently.

dishabhadra’s picture

dishabhadra commented
Status: Reviewed & tested by the community » Needs review
dishabhadra’s picture

dishabhadra commented
Assigned: mahipal46 » Unassigned
Status: Needs review » Closed (works as designed)

I am closing this request.