Problem/Motivation
We have a use case where the translator service wants to filter out content based on a set of criteria before the job is created. We couldn't find an appropriate place to do that.
Proposed resolution
Add an event and invoke it in \Drupal\tmgmt\ContinuousManager::addItem
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 2933917-additem-event-5-interdiff.txt | 15.33 KB | berdir |
| #5 | 2933917-additem-event-5.patch | 14.95 KB | berdir |
| #3 | 2933917-additem-event-2.patch | 10.13 KB | primsi |
| #3 | 2933917-additem-event-2.interdiff.txt | 3.58 KB | primsi |
| #2 | 2933917-additem-event.patch | 6.56 KB | primsi |
Comments
Comment #2
primsi commentedInitial patch, no tests yet.
Comment #3
primsi commentedStarting with tests, not sure if this is the direction we want to go.
Comment #4
berdirI think it makes more sense to name that class ContinuousEvents.
I'll try to improve the docs a bit here.
...Interface
.. ID
.
whether
improve this a bit as well.
continuous events
I think it's better to avoid the UI and just check if we have any jobs here, and then create a node with a different label that will be added.
.
Comment #5
berdirCleanup and moved the test to the existing kernel test coverage, just requires a few additional lines then.
interdiff is very big but it's mostly just comment changes and the moving the test.
Comment #6
berdirCommitted.