Problem/Motivation

Rather than hitting code standards as one-offs, let's do it all in one go.

See #2930971: Convert module to use short array syntax (new coding standard). & #2931003: Remove @file tag docblock.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 interdiff_3-4.txt872 bytesheddn
#4 2933908-4.patch55.41 KBheddn
#3 2933908.patch55.39 KBheddn
#2 2933908.patch8.68 KBheddn

Comments

heddn created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Active » Needs review
StatusFileSize
new 2933908.patch8.68 KB

Next steps:

  • Fix all the errors
  • Review
  • Commit
heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
StatusFileSize
new 2933908.patch55.39 KB

Here's a few more phpcs fixes and an updated phpcs.xml.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
StatusFileSize
new 2933908-4.patch55.41 KB
new interdiff_3-4.txt872 bytes

Yeah for tests!

The last submitted patch, 3: 2933908.patch, failed testing. View results

  • heddn committed 6f6f0b8 on 8.x-4.x 
    Issue #2933908 by heddn: Update phpcs.xml
heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.