Just opened the new Drush files and was greeted by a wall of yellow. Even though most of this is just PhpStorm's new pickiness about exception handling, we should still aim to fix those.

CommentFileSizeAuthor
#3 2933811-3--drush_coding_standards.patch16.69 KBdrunken monkey
#2 2933811-2--drush_coding_standards.patch16.7 KBdrunken monkey

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 2933811-2--drush_coding_standards.patch16.7 KB

This mostly just adds @throws tags where appropriate.
We might want to catch some of those and output a proper error message, but this is already a start, I'd say.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
StatusFileSize
new 2933811-3--drush_coding_standards.patch16.69 KB

Re-roll.

  • drunken monkey committed afeb07b on 8.x-1.x 
    Issue #2933811 by drunken monkey: Fixed coding standards in new Drush...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.