Border radius set to 0 does not effect the theme

Created PR to fix this.
https://github.com/goalgorilla/open_social/pull/761

Hey Lisa,

I think we can do better here. Instead of changing the if statements. Let's fix the underlying function that parses it.

I already made a related comment on the change that caused this regression here: https://github.com/goalgorilla/open_social/pull/669#discussion_r156110032

We can probably put the old code that was there before the refactor into the function. So then the contents of improved_theme_settings_get_setting (see https://github.com/goalgorilla/open_social/commit/96db617d77080272c10ade... ) would become more like:

/**
 * Function that returns a valid integer or FALSE.
 */
function improved_theme_settings_get_setting($setting, $themename) {
  // Fetch setting from the theme.
  $themevar = Xss::filter(theme_get_setting($setting, $themename));
  
  // Convert possible strings (e.g. "5 ") to proper integers.
  if (is_string($themevar)  && trim($card_radius) !== '') {
    $themevar = intval($themevar);
  }
  
  // If we have a valid integer value, use it.
  if (is_integer($themevar)) {
    return $themevar;
  }

  return FALSE;
}

The above code has been written in the comment field so may contain untested typoes. ^^

@kingdutch

Thanks for the input. For now, we have merged the initial commit (https://github.com/goalgorilla/open_social/pull/761) as this bug has been open for a while and some people are keen to get it fixed.

This is not really a frontend task, so I am reclassifying it and leaving it as needs work so someone with more Php knowledge can implement a better solution based on your proposed solution.

Marking as fixed for now as the original issue is solved as per pull/761. If we want to improve on it further we can do so in a different issue.