The documentation for ExtensionDiscovery::scanDirectory() says:
> * Recursively scans a base directory for the requested extension type.
But the method doesn't get the extension type as a parameter, nor is it set on the class as a property.
I don't see that the method is at all aware of the extension type being currently scanned for, and looking further down that method, it looks like it scans for all extension types:
// Determine extension type from info file.
$type = FALSE;
$file = $fileinfo->openFile('r');
while (!$type && !$file->eof()) {
preg_match('@^type:\s*(\'|")?(\w+)\1?\s*$@', $file->fgets(), $matches);
if (isset($matches[2])) {
$type = $matches[2];
}
}
if (empty($type)) {
continue;
}
...
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | fix-method-description-2932865-4.patch | 611 bytes | avpaderno |
Comments
Comment #2
joachim commentedComment #3
avpadernoComment #4
avpadernoComment #5
borisson_The new description does look better, no nits to pick here.
Comment #7
avpadernoI am setting it back to r&tbtc, since the patch passed the tests. I am not sure why it is said to fail.
Comment #9
catchCommitted c2d7454 and pushed to 8.5.x. Thanks!