Agreed mostly on the approach. Needs an MR and a few cleanups.

CommentFileSizeAuthor
#3 shield-multiple_user_support-2931945-3.patch2.15 KBTechnorange

Issue fork shield-2931945

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rajeevgole created an issue. See original summary.

deepchandra84’s picture

deepchandra84 commented

+1

Technorange’s picture

Technorange commented
StatusFileSize
new shield-multiple_user_support-2931945-3.patch2.15 KB

Apply the patch for version 8.x-1.7 it should adding a description for Credentials on /admin/config/system/shield

Description:
To add multiple username and password separate them by pipe (|).
e.g. Username: user1|user2 Password: pass1|pass2.
Note: You won\'t be able to use | within your username or password as | is being used as a separator.

tikaszvince’s picture

tikaszvince commented
Status: Active » Reviewed & tested by the community

Hi,

It looks good for me.
Thank you.

japerry made their first commit to this issue’s fork.

japerry’s picture

japerry
Location KOMK
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work

Issue is valid, as the http basic auth in Drupal works slightly differently. Pushed an MR to cleanup some of the otherwise good patch.

japerry opened merge request !41

japerry’s picture

japerry
Location KOMK
commented
Status: Needs work » Needs review

  • japerry committed 7fc166bf on 8.x-1.x 
    feat: Issue #2931945 by Technorange: Support multiple username and...
japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.