Problem/Motivation

advagg_ext_minify_requirements() is the currently the only hook_requirements that does not return a value. This makes the entry for 'Advagg External Minification: PHP shell_exec' look out of place on the Status report:

Proposed resolution

Return a value in advagg_ext_minify_requirements()

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

The entry for 'Advagg External Minification: PHP shell_exec' on the status report no longer looks out of place on the Status report.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 advagg-hook_requirements_should_return_value-2931746-2.patch1.57 KBidebr
#2 Screen Shot 2017-12-19 at 13.51.17.png20.91 KBidebr
#2 Screen Shot 2017-12-19 at 13.51.42.png53.52 KBidebr
Screen Shot 2017-12-19 at 13.40.56.png53.76 KBidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new Screen Shot 2017-12-19 at 13.51.42.png53.52 KB
new Screen Shot 2017-12-19 at 13.51.17.png20.91 KB
new advagg-hook_requirements_should_return_value-2931746-2.patch1.57 KB

Attached patch adds a value in advagg_ext_minify_requirements().

Error:

Ok:

idebr’s picture

idebr commented
Issue summary: View changes
nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Needs review » Fixed

That seems like a improvement in UX and consistency. Thanks for the patch, committed.

  • NickWilde committed cea5568 on 8.x-3.x authored by idebr 
    Issue #2931746 by idebr: advagg_ext_minify_requirements() should return...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.