This is a ultra trivial observation

In simple_gmap_theme() the default twig variable definitions defaults to NULL

Now that we have a simple_gmap.schema.yml they should shadow the defaults in

SimpleGMapFormatter::defaultSettings()

function simple_gmap_theme() {
  return [
    'simple_gmap_output' => [
      'variables' => [
        'include_map' => NULL,
        'include_static_map' => NULL,
        'include_link' => NULL,
        'include_text' => NULL,
        'address_text' => NULL,
        'width' => NULL,
        'height' => NULL,
        'static_scale' => NULL,
        'url_suffix' => NULL,
        'zoom' => NULL,
        'link_text' => NULL,
        'map_type' => NULL,
        'langcode' => NULL,
        'static_map_type' => NULL,
        'apikey' => NULL,
        'iframe_title' => '',
      ],
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

martin107 created an issue. See original summary.

smustgrave’s picture

Version: 8.x-1.x-dev » 4.0.x-dev
smustgrave’s picture

Priority: Minor » Major

This actually needs a bit of work. The variables being passed to the template, the schema, and what's listed in the hook_theme() don't fully line up.

  • smustgrave committed b520b226 on 4.0.x
    Issue #2931578 by smustgrave, martin107: Type consistency remove NULLs
    
smustgrave’s picture

Status: Active » Fixed
joseph.olstad’s picture

So this doesn't go into 3x?

Just wondering, I don't even see a 4x dev build

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.