Closed (fixed)
Project:
Simple Google Maps
Version:
4.0.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Reporter:
Created:
18 Dec 2017 at 20:11 UTC
Updated:
12 Feb 2025 at 17:49 UTC
Jump to comment: Most recent
This is a ultra trivial observation
In simple_gmap_theme() the default twig variable definitions defaults to NULL
Now that we have a simple_gmap.schema.yml they should shadow the defaults in
SimpleGMapFormatter::defaultSettings()
function simple_gmap_theme() {
return [
'simple_gmap_output' => [
'variables' => [
'include_map' => NULL,
'include_static_map' => NULL,
'include_link' => NULL,
'include_text' => NULL,
'address_text' => NULL,
'width' => NULL,
'height' => NULL,
'static_scale' => NULL,
'url_suffix' => NULL,
'zoom' => NULL,
'link_text' => NULL,
'map_type' => NULL,
'langcode' => NULL,
'static_map_type' => NULL,
'apikey' => NULL,
'iframe_title' => '',
],
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
smustgrave commentedComment #3
smustgrave commentedThis actually needs a bit of work. The variables being passed to the template, the schema, and what's listed in the hook_theme() don't fully line up.
Comment #6
smustgrave commentedComment #7
joseph.olstadSo this doesn't go into 3x?
Just wondering, I don't even see a 4x dev build