Problem/Motivation

There is no default list selection by default with the handler.

If i switch a list selection, the form of the handler doesn't update.
Groups only get visible if i save and edit again.

Proposed resolution

Use ajax to refresh the form.

User interface changes

Ajaxification.

CommentFileSizeAuthor
#4 use_ajax_to_update_lists-2931405-4.patch2.89 KBmbovan
#2 use_ajax_to_update_lists-2931405-2.patch2.98 KBmbovan

Comments

miro_dietiker created an issue. See original summary.

mbovan’s picture

mbovan commented
Status: Active » Needs review
Related issues: +#2906484: Subscribing webform submitters to a hidden Mailchimp interest group?, +#2920238: Interest Groups not showing in handler config form
StatusFileSize
new use_ajax_to_update_lists-2931405-2.patch2.98 KB

This patch implements an ajax callback on a list select element which updates interest groups accordingly (no need to save a handler and edit the form).

As this overlaps with the related issue, the patch also includes fixes for #2920238: Interest Groups not showing in handler config form and #2906484: Subscribing webform submitters to a hidden Mailchimp interest group?. In case these 2 issues get committed first, I will reroll this patch on top of it.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Please also provide a patch on top of the other ones for review and committing once the other two are in.

mbovan’s picture

mbovan commented
StatusFileSize
new use_ajax_to_update_lists-2931405-4.patch2.89 KB

As #2906484: Subscribing webform submitters to a hidden Mailchimp interest group? and #2920238: Interest Groups not showing in handler config form were fixed, here is the rerolled patch.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me and works for us.

  • mbovan committed 123838d on 8.x-5.x 
    Issue #2931405 by mbovan: Use Ajax to refresh form selection
mbovan’s picture

mbovan commented
Status: Reviewed & tested by the community » Fixed

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.