Enabling core Field layout module fatals during installation

I received a version of this bug while in 8.5.1 core. I had Display Suite installed. I installed Field Layout.
Then I could not get to several admin views. I tried to back out by uninstalling Field Layout. Which died with the same error. So then I uninstalled Display Suite. That let me back in to admin/config/people/accounts, but I still can't uninstall Field Layout. Error log shows instances of this error for each action that I was unable to complete:
TypeError: Argument 1 passed to {closure}() must implement interface Drupal\field_layout\Display\EntityDisplayWithLayoutInterface, instance of Drupal\layout_builder\Entity\LayoutBuilderEntityViewDisplay given in {closure}() (line 34 of /srv/bindings/222579ed6ff54e7da2207cfdbfb903eb/code/core/modules/field_layout/field_layout.install)

Field layout and DS works perfectly on a lot of sites these days.
Are you sure you're on the correct branch and run update.php?

If DS is installed before Field Layout, installing the latter cause the error in #6, both in drush and from the Extend UI.

I believe the test is not failing because by installing them together the module_installer sort the array putting field_layout before ds and so not triggering the bug.

I'm trying to validate this theory.

Yep, it does fail locally if not installed together with the other modules.

I think this is a core bug in field_layout.install

/**
 * Implements hook_install().
 */
function field_layout_install() {
  // Ensure each entity display has a layout.
  $entity_save = function (EntityDisplayWithLayoutInterface $entity) {
    $entity->ensureLayout()->save();
  };
  array_map($entity_save, EntityViewDisplay::loadMultiple());
  array_map($entity_save, EntityFormDisplay::loadMultiple());

  // Invalidate the render cache since all content will now have a layout.
  Cache::invalidateTags(['rendered']);
}

The code assumes every EntityViewDisplay extends EntityDisplayWithLayoutInterface. This is not the case when DS is installed first.

And it's caused by:

/**
 * Implements hook_entity_type_alter().
 */
function ds_entity_type_alter(array &$entity_types) {
  // Undo field_layout changes to EntityViewDisplay.
  if (\Drupal::moduleHandler()->moduleExists('field_layout')) {
    $entity_types['entity_view_display']->setClass($entity_types['entity_view_display']->getOriginalClass());
    if (\Drupal::moduleHandler()->moduleExists('field_ui')) {
      $entity_types['entity_view_display']->setFormClass('edit', 'Drupal\field_ui\Form\EntityViewDisplayEditForm');
    }
  }
}

Moving to the Drupal core queue.

Is this reproducible on a supported version of Drupal?

I gather that you get an error if ds is installed and then you enable the field layout module. If that is correct then I could not reproduce this on Drupal 10.0.x. Since I am not sure if that is the correct steps to cause the error I am changing the status to PMNMI to see if this is still a problem.

Since there hasn't been a follow up to #24 going to close for now.

If still a bug please reopen.

Thanks!

Updating tags per Issue tags field and Issue tags -- special tags and for issue #3565085: Drupal core issue tag cleanup.

There are only 3 issues in core using 'needs patch', which isn't very useful on closed issues.