Two change records to check and adapt to:
getMock() deprecated in \Drupal\Tests\UnitTestCase, \Drupal\KernelTests\KernelTestBase and \Drupal\Tests\BrowserTestBase\Drupal\Tests\Listeners classesProbably we just need to change getMock() calls in our code – to getMockBuilder()->create() (or whatever it is) for now, probably, since we can't use createMock() yet until we depend on Drupal 8.5. (Or we add our own createMock() for now? Maybe that would make most sense. In any case, add a @todo comment about the follow-up for when we increase the Core dependency version.)
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 2930839-5--phpunit_6_compatibility.patch | 33.15 KB | drunken monkey |
Comments
Comment #2
drunken monkeyHm, actually, the best course of action might be to wait with this until we increase the Core dependency.
Comment #3
drunken monkeyIn addition, running the tests with the new PHPUnit version currently generates 13 warnings like the following:
Obviously, they changed something about the definition of mocked methods.
Comment #4
drunken monkeyAlso see this change record: PHPUnit 6 is used for testing on PHP 7.0+.
(I don't see anything new there, though, but might explain the recent test fails.)
Comment #5
drunken monkeyHm, actually, we can just update this now – since it's only the test layer, it doesn't matter that much if it's not compatible with 8.4 anymore (which, after all, is EOL now and therefore not tested against anymore anyways).
Comment #7
drunken monkeyFixes current HEAD tests, so: committed.
If someone still wants to review, that would still be welcome, but the changes are mostly trivial.