View mode class is not built correctly in media.html.twig

Hi slashrsm,

I have applied the patch #2 and it has applied successfully without any issue. But I'm unable to test it. Could please provide a Test case to test the patch.

Thanks.

Thanks you slashrsm, this fixed our problem.

To sarguna raj M, I don't really see the point of a Test case pour this.
Just create a media, any type, and check the html if you see the class media--view-mode-your_view_id on it.

I think here is a test which works.

+++ b/core/modules/media/tests/src/Kernel/MediaTemplateTest.php
@@ -0,0 +1,50 @@
+ * Tests the templates shipped by media module.

it's actually shipped by classy, and we're also only testing that now I think?

Also wondering if a kernel test for this really makes sense or if we should just add an assertContains() to \Drupal\Tests\media\Functional\MediaUiFunctionalTest or a similar existing actual web test?

That is a good point!

Wow, it is not obvious that cssSelect works different on a different environment.

Just removed the print_r() leftover, I expect this will pass.

Came here to RTBC, but tiny nit, this is also equivalent to:

  $this->assertSession()->elementsCount('css', '.media--view-mode-full', 1);

Whoops, this was already RTBC to begin with. Setting back for #17. If #18 passes, I suppose we can use that one too.

#18 looks fine, agreed that if that passes, that's the patch to commit :)

Yeah, I kind of RTBC'd my own patch but I just removed a debug line. This way it's better anyway :)

Looks good. Committed b888a36 and pushed to 8.6.x. Also cherry-picked to 8.5.x 76c103f because it seems highly unlikely that anyone would have themed using the broken class name. Thanks!