\Drupal\linkit\Plugin\Linkit\Substitution\Media assumes contrib version of Media entity and fails miserably if trying to throw core version at it. Other modules usually created new branch/major version to be able to support both at the same time. Here we might say that 8.x-5.x supports core and 8.x-4.x contrib?

CommentFileSizeAuthor
#2 2930171_2.patch8.66 KBslashrsm

Comments

slashrsm created an issue. See original summary.

slashrsm’s picture

slashrsm commented
Status: Active » Needs review
StatusFileSize
new 2930171_2.patch8.66 KB

Implemented. Also fixed the test.

Status: Needs review » Needs work

The last submitted patch, 2: 2930171_2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

slashrsm’s picture

slashrsm commented
Status: Needs work » Needs review

Test fails are not related: https://www.drupal.org/node/719864/qa

Status: Needs review » Needs work

The last submitted patch, 2: 2930171_2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

anon’s picture

anon
Primary language Swedish
Location Gothenburg
commented
Status: Needs work » Fixed

Awsome patch, thanks!

  • anon committed 1084887 on 8.x-5.x authored by slashrsm 
    Issue #2930171 by slashrsm, anon: Support core Media entity
berdir’s picture

berdir
Primary language German
Location Switzerland
commented

The problem with this patch is that it broke compatibility with media_entity, obviously.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

acbramley’s picture

acbramley commented

Yeah it's a shame that media_entity support has just been thrown away on 5.x considering the integration was added in 5.x...