Problem/Motivation

Steps to reproduce:

  1. make sure the "Translations download publication status" config is set as "Same as source content" and that the menu translation mode is set as "Translate and Localize"
  2. create a menu link and disable it so it does not appear on the frontend
  3. Upload and download the translation

Expected result: The menu link is disabled
Actual result: The menu link is enabled regardless of the source status

Proposed resolution

We can copy the status and weight from the translated entity when creating the drupal translation.
Making sure the parent link correlates to the original langauge may be trickier.

CommentFileSizeAuthor
#4 menu-links-lose-their-status-and-weight-2930014-4.patch2.01 KBjbhovik

Comments

nbouhid created an issue. See original summary.

jbhovik’s picture

jbhovik commented

@nbouhid,

Thanks for this report as well. I did have a question; are you using the entity_menu_links module to translate menu links as entities? Also, are you using the entity_translation module on your site?

nbouhid’s picture

nbouhid commented

Yes, I'm using entity_menu_links because we need to deploy these entities across environments.
entity_translation is installed but not in use for menu links.

jbhovik’s picture

jbhovik commented
StatusFileSize
new menu-links-lose-their-status-and-weight-2930014-4.patch2.01 KB
jbhovik’s picture

jbhovik commented

@nbouhid,

I've attached a patch that should fix the weights and statuses for newly translated menu links. Try it out and see if it meets your needs.

Like you mentioned, keeping the parent-child relationships is a little bit more difficult. We actually discussed it when we initially created the advanced handling of menu links, but found that the operation to deliver the parent-child relationship would add unwanted complexity.

EPortela’s picture

EPortela commented
Status: Active » Fixed

Patch was reviewed, tested internally, and committed as part of 7.x-7.26. This should fix the issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.