When I try to install page_manager_ui with php 7.2.0 I get the following fatal error

Fatal error: Declaration of Drupal\page_manager_ui\Form\VariantPluginAddBlockForm::buildForm(array $form, Drupal\Core\Form\FormStateInterface $form_state, ?Symfony\Component\HttpFoundation\Request $request = NULL, $block_display = NULL, $block_id = NULL) must be compatible with Drupal\page_manager_ui\Form\VariantPluginConfigureBlockFormBase::buildForm(array $form, Drupal\Core\Form\FormStateInterface $form_state, $block_display = NULL, $block_id = NULL) in /var/www/html/web/modules/contrib/page_manager/page_manager_ui/src/Form/VariantPluginAddBlockForm.php on line 20

CommentFileSizeAuthor
#16 2929896-16.patch862 byteseclipsegc
#2 2929896-php72-fatal-2.patch2.05 KBrodrigoaguilera

Comments

rodrigoaguilera created an issue. See original summary.

rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
commented
Status: Active » Needs review
StatusFileSize
new 2929896-php72-fatal-2.patch2.05 KB

Seems like the module installs with this patch

Status: Needs review » Needs work

The last submitted patch, 2: 2929896-php72-fatal-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: +PHP 7.2
jasonellington’s picture

jasonellington commented

Hello, is there any resolution to this issue?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

It isn't really safe to use Drupal with PHP 7.2 yet.

alexrayu’s picture

alexrayu commented

Confirmed this issue with 7.2, resolved by downgrading to 7.1.

CryptoKiwi’s picture

CryptoKiwi commented

This issue is still present, and with Drupal 8.5 PHP 7.2 is recommended. Patch from #2 does not work sadly.

thiagomoraesp’s picture

thiagomoraesp commented

Same here with PHP 7.2.3 =(

manuel.adan’s picture

manuel.adan
Location 🌌
commented
Status: Needs work » Needs review

#2 works for me in Drupal 8.5.0 (standard clean installation) + PHP 7.2.2, latest page_manager-dev (8.x-4.0-beta2+4-dev) or beta4 + #2918564: Update 'page_manager.variant_route_filter' service according to core changes

manuel.adan’s picture

manuel.adan
Location 🌌
commented
Related issues: +#2923286: Fatal error in Drupal\panels\Form\PanelsAddBlockForm::buildForm() with PHP 7.2

Also check that your site is not affected by the very similar issue #2923286: Fatal error in Drupal\panels\Form\PanelsAddBlockForm::buildForm() with PHP 7.2 in panels.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2787419: Plan for Page Manager 8.x-4.0 release
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Confirm that it works
- PHP 7.2.4
- core 8.5.1 (8.6-dev as well)
- PM 8.4-dev + patch

andypost’s picture

andypost
he/him
Primary language Russian
commented

This fails on 7.2 because of interface https://3v4l.org/6p5Fe

if you remove implements aa code starts to work)

andypost’s picture

andypost
he/him
Primary language Russian
commented

The same fix landed in ds module #2779243: Method declaration incompatibility

eclipsegc’s picture

eclipsegc commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 2929896-16.patch862 bytes

Try this patch and tell me if it fixes it.

Eclipse

  • EclipseGc committed 3d1ecb4 on 8.x-1.x 
    Issue #2929896 by rodrigoaguilera, EclipseGc: PHP 7.2.0 fatal error
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Fixed

@Eclipse thanx a lot! This way better and the same as panels

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Fixed » Reviewed & tested by the community

It was commited to 1.x so still needed for 4.x

  • japerry committed 0d813bc on 8.x-4.x authored by EclipseGc 
    Issue #2929896 by rodrigoaguilera, EclipseGc: PHP 7.2.0 fatal error
japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

Looks good, fixed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.