CommentFileSizeAuthor
#4 VBO_After patch.png36.03 KBriddhi.addweb
#2 2929872-2.patch457 bytesopdavies

Comments

opdavies created an issue. See original summary.

opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented
Status: Active » Needs review
StatusFileSize
new 2929872-2.patch457 bytes
riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Reviewed & tested by the community

@opdavies, Thanks for the patch, your patch works for me As I checked it manually by applying it in module file.
PFA screenshots for the same.

riddhi.addweb’s picture

riddhi.addweb commented
StatusFileSize
new VBO_After patch.png36.03 KB
graber’s picture

graber commented

Thanks guys, will be committed right after #2929873: Prepare API for multi-page selections.

  • Graber committed 6011467 on 8.x-1.x authored by opdavies 
    Issue #2929872 by opdavies, Jigar.addweb: Fix operatios typo in README
graber’s picture

graber commented
Status: Reviewed & tested by the community » Fixed

Committed, #2929873 will be in the 2.x branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

alison’s picture

alison
she/her
commented

Looks like this didn't make it into 2.x or 3.x?

https://git.drupalcode.org/project/views_bulk_operations/blob/8.x-2.x/RE...
https://git.drupalcode.org/project/views_bulk_operations/blob/8.x-3.x/RE...

..............
@Graber would you like a new patch for 3.x, or do you want to just cherry-pick commit #6011467 into the 3.x branch, or?

graber’s picture

graber commented

:+1:

alison’s picture

alison
she/her
commented

Crap, sorry I missed your reply -- which option are you saying "+1" to? 😁

(Or has it been addressed since then?)