I have an event content type that have enabled Add to Calendar button.
After selecting fields that I want to be used in Calendar email I am getting strict warnings every time I save any Event.

CommentFileSizeAuthor
#2 addtocalendar-passed_by_reference-2929782-2-d8.patch666 bytesypomiak
addToCalendar.png95.45 KBypomiak

Comments

ypomiak created an issue. See original summary.

ypomiak’s picture

ypomiak commented
StatusFileSize
new addtocalendar-passed_by_reference-2929782-2-d8.patch666 bytes

adding patch to fix this issue

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Reviewed & tested by the community

The patch works for me, and the code looks good.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Assigned: Unassigned » yogeshmpawar
yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented

Looks good to me, +1 for RTBC.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Assigned: yogeshmpawar » Unassigned
gg24’s picture

gg24 commented

Looks good to me. Pushing it to the repo.

  • gg24 committed 761aad4 on 8.x-3.x authored by ypomiak 
    Issue #2929782 by ypomiak, gg24: Add To Calendar throwing strict warning...
gg24’s picture

gg24 commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch @ypomiak.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.