Follow-up from #2895001: Use the bundle label (e.g. "Media type") instead of "Bundles" in the Entity Reference field configuration.

In that issue getBundleLabel() was changed to always return a string, so the @return in the current interface docblock is wrong.

CommentFileSizeAuthor
#2 2929076-2.patch535 bytesmarcoscano

Comments

marcoscano created an issue. See original summary.

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
commented
Assigned: marcoscano » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2929076-2.patch535 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 2929076-2.patch, failed testing. View results

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Reviewed & tested by the community

LGTM.

  • larowlan committed bc1e39c on 8.5.x 
    Issue #2929076 by marcoscano: Fix wrong \Drupal\Core\Entity\...

  • larowlan committed 261d0fe on 8.4.x 
    Issue #2929076 by marcoscano: Fix wrong \Drupal\Core\Entity\...

  • larowlan committed cb55389 on 8.4.x 
    Revert "Issue #2929076 by marcoscano: Fix wrong \Drupal\Core\Entity\...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed as bc1e39c and pushed to 8.5.x.

I cherry-picked this to 8.4.x, but then realised that the issue this is a follow up for isn't in 8.4.x, so reverted that

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.