Problem/Motivation

PHPUnit based tests have $this->root available, still many tests use \Drupal::root()
This should ideally wait until #2907728: Installer: Convert system functional tests to phpunit is done.

Proposed resolution

Convert them over.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 2928710.patch46.98 KBborisson_

Comments

dawehner created an issue. See original summary.

ioana apetri’s picture

ioana apetri commented
Assigned: Unassigned » ioana apetri

I want to work on this issue.
Starting to prepare my env.

mayurjadhav’s picture

mayurjadhav commented
Issue tags: +DrupalMumbaiCodeSprint

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Active » Needs review
StatusFileSize
new 2928710.patch46.98 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Assigned: ioana apetri » Unassigned

Also unassigned this issue.

idebr’s picture

idebr commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
  1. Applied patch #6 locally and did a search to confirm there a no more PHPUnit based tests that refer to \Drupal::root()
  2. Updated the issue summary to reflect the change only applied to PHPUnit based tests.
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed c00b97b and pushed to 8.6.x. Thanks!

  • catch committed c00b97b on 8.6.x 
    Issue #2928710 by borisson_, dawehner, idebr: Eliminate usages of \...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.